You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Espen Wiborg (JIRA)" <ji...@codehaus.org> on 2008/11/13 22:20:13 UTC
[jira] Created: (MNG-3838) Some POMs fail to parse if the are
subject to ModelContainer joining
Some POMs fail to parse if the are subject to ModelContainer joining
--------------------------------------------------------------------
Key: MNG-3838
URL: http://jira.codehaus.org/browse/MNG-3838
Project: Maven 2
Issue Type: Bug
Components: POM
Affects Versions: 3.0
Reporter: Espen Wiborg
Priority: Blocker
Attachments: example.zip
With Maven 3.0-SNAPSHOT built from svn r713815, the POM in the attachment fails to parse with the output in fail.log. The interesting bit is reproduced here:
{noformat}
java.io.IOException: org.codehaus.plexus.util.xml.pull.XmlPullParserException: end tag name </plugin> must match start tag name <dependencies> from line 12 (position: START_TAG seen ...<dependencies></plugin>... @12:24) :
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0" >
<modelVersion>4.0.0</modelVersion>
<groupId>testing</groupId>
<artifactId>testing</artifactId>
<version>1</version>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<dependencies></plugin>
<plugin>
[...lots more...]
{noformat}
As far as I can make out, the problem is that the ModelContainer joining carried out in ModelTransformerContext.transform (on line 269) fails to take into account that it may leave the wrapper collection empty. Such an empty collection then leads ModelMarshaller astray later.
The example POM is a stripped-down version of the org.apache.cxf:cfx-parent:2.1 POM, which is how I discovered the issue.
This broke sometime after 2008-10-13.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3838) [regression] Some POMs fail to parse if
the are subject to ModelContainer joining
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann closed MNG-3838.
----------------------------------
Assignee: Shane Isbell
Resolution: Fixed
Fix Version/s: (was: 3.0-alpha-3)
3.0-alpha-1
Fixed in [r727855|http://svn.eu.apache.org/viewvc?view=rev&revision=727855].
> [regression] Some POMs fail to parse if the are subject to ModelContainer joining
> ---------------------------------------------------------------------------------
>
> Key: MNG-3838
> URL: http://jira.codehaus.org/browse/MNG-3838
> Project: Maven 2
> Issue Type: Bug
> Components: POM
> Affects Versions: 3.0-alpha-1
> Reporter: Espen Wiborg
> Assignee: Shane Isbell
> Priority: Blocker
> Fix For: 3.0-alpha-1
>
> Attachments: example.zip
>
>
> With Maven 3.0-SNAPSHOT built from svn r713815, the POM in the attachment fails to parse with the output in fail.log. The interesting bit is reproduced here:
> {noformat}
> java.io.IOException: org.codehaus.plexus.util.xml.pull.XmlPullParserException: end tag name </plugin> must match start tag name <dependencies> from line 12 (position: START_TAG seen ...<dependencies></plugin>... @12:24) :
> <project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0" >
> <modelVersion>4.0.0</modelVersion>
> <groupId>testing</groupId>
> <artifactId>testing</artifactId>
> <version>1</version>
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-checkstyle-plugin</artifactId>
> <dependencies></plugin>
> <plugin>
> [...lots more...]
> {noformat}
> As far as I can make out, the problem is that the ModelContainer joining carried out in ModelTransformerContext.transform (on line 269) fails to take into account that it may leave the wrapper collection empty. Such an empty collection then leads ModelMarshaller astray later.
> The example POM is a stripped-down version of the org.apache.cxf:cfx-parent:2.1 POM, which is how I discovered the issue.
> This broke sometime after 2008-10-13.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3838) [regression] Some POMs fail to parse if
the are subject to ModelContainer joining
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-3838:
------------------------------
Fix Version/s: 3.0-alpha-3
Summary: [regression] Some POMs fail to parse if the are subject to ModelContainer joining (was: Some POMs fail to parse if the are subject to ModelContainer joining)
> [regression] Some POMs fail to parse if the are subject to ModelContainer joining
> ---------------------------------------------------------------------------------
>
> Key: MNG-3838
> URL: http://jira.codehaus.org/browse/MNG-3838
> Project: Maven 2
> Issue Type: Bug
> Components: POM
> Affects Versions: 3.0-alpha-1
> Reporter: Espen Wiborg
> Priority: Blocker
> Fix For: 3.0-alpha-3
>
> Attachments: example.zip
>
>
> With Maven 3.0-SNAPSHOT built from svn r713815, the POM in the attachment fails to parse with the output in fail.log. The interesting bit is reproduced here:
> {noformat}
> java.io.IOException: org.codehaus.plexus.util.xml.pull.XmlPullParserException: end tag name </plugin> must match start tag name <dependencies> from line 12 (position: START_TAG seen ...<dependencies></plugin>... @12:24) :
> <project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0" >
> <modelVersion>4.0.0</modelVersion>
> <groupId>testing</groupId>
> <artifactId>testing</artifactId>
> <version>1</version>
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-checkstyle-plugin</artifactId>
> <dependencies></plugin>
> <plugin>
> [...lots more...]
> {noformat}
> As far as I can make out, the problem is that the ModelContainer joining carried out in ModelTransformerContext.transform (on line 269) fails to take into account that it may leave the wrapper collection empty. Such an empty collection then leads ModelMarshaller astray later.
> The example POM is a stripped-down version of the org.apache.cxf:cfx-parent:2.1 POM, which is how I discovered the issue.
> This broke sometime after 2008-10-13.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3838) Some POMs fail to parse if the are
subject to ModelContainer joining
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-3838:
-----------------------------------
Affects Version/s: (was: 3.0)
3.0-alpha-1
The example POM has been added to the IT suite, thanks very much Espen!
> Some POMs fail to parse if the are subject to ModelContainer joining
> --------------------------------------------------------------------
>
> Key: MNG-3838
> URL: http://jira.codehaus.org/browse/MNG-3838
> Project: Maven 2
> Issue Type: Bug
> Components: POM
> Affects Versions: 3.0-alpha-1
> Reporter: Espen Wiborg
> Priority: Blocker
> Attachments: example.zip
>
>
> With Maven 3.0-SNAPSHOT built from svn r713815, the POM in the attachment fails to parse with the output in fail.log. The interesting bit is reproduced here:
> {noformat}
> java.io.IOException: org.codehaus.plexus.util.xml.pull.XmlPullParserException: end tag name </plugin> must match start tag name <dependencies> from line 12 (position: START_TAG seen ...<dependencies></plugin>... @12:24) :
> <project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0" >
> <modelVersion>4.0.0</modelVersion>
> <groupId>testing</groupId>
> <artifactId>testing</artifactId>
> <version>1</version>
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-checkstyle-plugin</artifactId>
> <dependencies></plugin>
> <plugin>
> [...lots more...]
> {noformat}
> As far as I can make out, the problem is that the ModelContainer joining carried out in ModelTransformerContext.transform (on line 269) fails to take into account that it may leave the wrapper collection empty. Such an empty collection then leads ModelMarshaller astray later.
> The example POM is a stripped-down version of the org.apache.cxf:cfx-parent:2.1 POM, which is how I discovered the issue.
> This broke sometime after 2008-10-13.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira