You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/03/01 15:45:13 UTC
[GitHub] couchdb-couch pull request: add _changes?feed=stream sugar for con...
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-couch/pull/40
add _changes?feed=stream sugar for continuous
allow `feed=stream` as sugar for `continuous` which is hard to
type.
closes COUCHDB-2237
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-couch 2237-stream
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/40.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #40
----
commit f9eaa6ab2b9b6e748ce8a55c05c8944c0cad8034
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2015-03-01T14:44:25Z
add _changes?feed=stream sugar for continuous
allow `feed=stream` as sugar for `continuous` which is hard to
type.
closes COUCHDB-2237
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add _changes?feed=stream sugar for con...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/40#issuecomment-76600674
Test here is missed. This will cause dependency on #35 PR. Let's try to get it merged first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add _changes?feed=stream sugar for con...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/40#issuecomment-77611212
cool (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add _changes?feed=stream sugar for con...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/40#issuecomment-77608180
+1 in general.
Btw, in light of [COUCHDB-2562](https://issues.apache.org/jira/browse/COUCHDB-2562) how do you feel is "stream" feed type is good one or there could be something better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add _changes?feed=stream sugar for con...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-couch/pull/40#issuecomment-82680619
do you think i am ready to merge?
https://github.com/apache/couchdb/pull/307 shuffles old code a bit around that takes care of safari browsers, but maybe removing browser compatibility is a separate task
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add _changes?feed=stream sugar for con...
Posted by robertkowalski <gi...@git.apache.org>.
GitHub user robertkowalski reopened a pull request:
https://github.com/apache/couchdb-couch/pull/40
add _changes?feed=stream sugar for continuous
allow `feed=stream` as sugar for `continuous` which is hard to
type.
PRs for the change:
https://github.com/apache/couchdb/pull/307
https://github.com/apache/couchdb-couch/pull/40
https://github.com/apache/couchdb-chttpd/pull/28
closes COUCHDB-2237
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-couch 2237-stream
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/40.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #40
----
commit dfeb8ddb337631afd88d2b6d0648e9d1d1996059
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2015-03-01T14:44:25Z
add _changes?feed=stream sugar for continuous
allow `feed=stream` as sugar for `continuous` which is hard to
type.
PRs for the change:
https://github.com/apache/couchdb/pull/307
https://github.com/apache/couchdb-couch/pull/40
https://github.com/apache/couchdb-chttpd/pull/28
closes COUCHDB-2237
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add _changes?feed=stream sugar for con...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-couch/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add _changes?feed=stream sugar for con...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-couch/pull/40#issuecomment-117314112
this got merged as d95005d4399047c52b5655cae6eb558258b8e6a5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add _changes?feed=stream sugar for con...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-couch/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add _changes?feed=stream sugar for con...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-couch/pull/40#issuecomment-77608932
yes, i think stream is good. it is a stream of newline separated json objects
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add _changes?feed=stream sugar for con...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/40#issuecomment-82822928
I left a comment about error message - may be there is a way to improve it. Cleaning up JavaScript test suite is indeed one big separate issue. In the end all is good for me (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add _changes?feed=stream sugar for con...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/40#issuecomment-116790206
@robertkowalski ping (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---