You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by pa...@apache.org on 2019/02/24 10:12:05 UTC

[commons-text] branch master updated: Do not enable checkstyle modules which results are always suppressed.

This is an automated email from the ASF dual-hosted git repository.

pascalschumacher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-text.git


The following commit(s) were added to refs/heads/master by this push:
     new c62b177  Do not enable checkstyle modules which results are always suppressed.
c62b177 is described below

commit c62b177c7e649729b42794d79c57bd504b17ce8c
Author: Pascal Schumacher <pa...@gmx.net>
AuthorDate: Sun Feb 24 11:11:59 2019 +0100

    Do not enable checkstyle modules which results are always suppressed.
---
 checkstyle-suppressions.xml | 6 ------
 checkstyle.xml              | 6 ------
 2 files changed, 12 deletions(-)

diff --git a/checkstyle-suppressions.xml b/checkstyle-suppressions.xml
index dcc57fe..2d6e4b1 100644
--- a/checkstyle-suppressions.xml
+++ b/checkstyle-suppressions.xml
@@ -19,12 +19,6 @@
    limitations under the License.
 -->
 <suppressions>
-  <suppress checks="AvoidInlineConditionals" files=".+\.java" />
-  <suppress checks="FinalParameters" files=".+\.java" />
-  <suppress checks="HiddenField" files=".+\.java" />
-  <suppress checks="DesignForExtension" files=".+\.java" />
-  <suppress checks="HideUtilityClassConstructor" files=".+\.java" />
-  <suppress checks="VisibilityModifier" files=".+\.java" />
   <suppress checks="LocalFinalVariableName" files="FormattableUtils.java" />
   <suppress checks="MagicNumber" files="JaccardDistance.java" />
   <suppress checks="MagicNumber" files="JaccardSimilarity.java" />
diff --git a/checkstyle.xml b/checkstyle.xml
index de7dad0..c72d854 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -176,10 +176,8 @@
 
         <!-- Checks for common coding problems               -->
         <!-- See http://checkstyle.sf.net/config_coding.html -->
-        <module name="AvoidInlineConditionals"/>
         <module name="EmptyStatement"/>
         <module name="EqualsHashCode"/>
-        <module name="HiddenField"/>
         <module name="IllegalInstantiation"/>
         <module name="InnerAssignment"/>
         <module name="MagicNumber"/>
@@ -189,17 +187,13 @@
 
         <!-- Checks for class design                         -->
         <!-- See http://checkstyle.sf.net/config_design.html -->
-        <module name="DesignForExtension"/>
         <module name="FinalClass"/>
-        <module name="HideUtilityClassConstructor"/>
         <module name="InterfaceIsType"/>
-        <module name="VisibilityModifier"/>
 
 
         <!-- Miscellaneous other checks.                   -->
         <!-- See http://checkstyle.sf.net/config_misc.html -->
         <module name="ArrayTypeStyle"/>
-        <module name="FinalParameters"/>
         <module name="TodoComment"/>
         <module name="UpperEll"/>