You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Zhen Zhang <ne...@gmail.com> on 2013/08/26 22:41:47 UTC
Review Request 13835: [HELIX-225] fix helix-examples package build error
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13835/
-----------------------------------------------------------
Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna.
Bugs: HELIX-225
Repository: helix-git
Description
-------
commit f73b3a7ae4398d61013899ee5eb758d4f2d1143e
Author: zzhang <zz...@uci.edu>
Date: Mon Aug 26 13:40:33 2013 -0700
[HELIX-225] fix helix-examples package build error
:100644 100644 37bccf3... 07080ea... M helix-examples/src/test/conf/testng.xml
Diffs
-----
helix-examples/src/test/conf/testng.xml 37bccf3
Diff: https://reviews.apache.org/r/13835/diff/
Testing
-------
Thanks,
Zhen Zhang
Re: Review Request 13835: [HELIX-225] fix helix-examples package build error
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13835/#review25576
-----------------------------------------------------------
Ship it!
Ship It!
- Kanak Biscuitwala
On Aug. 26, 2013, 8:41 p.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13835/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 8:41 p.m.)
>
>
> Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-225
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit f73b3a7ae4398d61013899ee5eb758d4f2d1143e
> Author: zzhang <zz...@uci.edu>
> Date: Mon Aug 26 13:40:33 2013 -0700
>
> [HELIX-225] fix helix-examples package build error
>
> :100644 100644 37bccf3... 07080ea... M helix-examples/src/test/conf/testng.xml
>
>
> Diffs
> -----
>
> helix-examples/src/test/conf/testng.xml 37bccf3
>
> Diff: https://reviews.apache.org/r/13835/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request 13835: [HELIX-225] fix helix-examples package build error
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13835/#review25685
-----------------------------------------------------------
Ship it!
Ship It!
- Kanak Biscuitwala
On Aug. 28, 2013, 8:21 p.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13835/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 8:21 p.m.)
>
>
> Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-225
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit f73b3a7ae4398d61013899ee5eb758d4f2d1143e
> Author: zzhang <zz...@uci.edu>
> Date: Mon Aug 26 13:40:33 2013 -0700
>
> [HELIX-225] fix helix-examples package build error
>
> :100644 100644 37bccf3... 07080ea... M helix-examples/src/test/conf/testng.xml
>
>
> Diffs
> -----
>
> helix-examples/src/main/config/log4j.properties e69de29
>
> Diff: https://reviews.apache.org/r/13835/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request 13835: [HELIX-225] fix helix-examples package build error
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13835/
-----------------------------------------------------------
(Updated Aug. 28, 2013, 8:21 p.m.)
Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna.
Changes
-------
the build error is caused by missing config folder under helix-examples/src/main. add the folder and a default log4j.properties
Bugs: HELIX-225
Repository: helix-git
Description
-------
commit f73b3a7ae4398d61013899ee5eb758d4f2d1143e
Author: zzhang <zz...@uci.edu>
Date: Mon Aug 26 13:40:33 2013 -0700
[HELIX-225] fix helix-examples package build error
:100644 100644 37bccf3... 07080ea... M helix-examples/src/test/conf/testng.xml
Diffs (updated)
-----
helix-examples/src/main/config/log4j.properties e69de29
Diff: https://reviews.apache.org/r/13835/diff/
Testing
-------
Thanks,
Zhen Zhang