You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Stefan Egli (Jira)" <ji...@apache.org> on 2020/11/04 12:58:00 UTC

[jira] [Commented] (OAK-9159) Add test support to NodeStoreTask

    [ https://issues.apache.org/jira/browse/OAK-9159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226034#comment-17226034 ] 

Stefan Egli commented on OAK-9159:
----------------------------------

Note that with [https://github.com/apache/jackrabbit-oak/pull/244] we no longer need this change. I would therefore suggest to close this ticket as won't fix. [~jsedding] , wdyt?

> Add test support to NodeStoreTask
> ---------------------------------
>
>                 Key: OAK-9159
>                 URL: https://issues.apache.org/jira/browse/OAK-9159
>             Project: Jackrabbit Oak
>          Issue Type: Test
>          Components: documentmk
>    Affects Versions: 1.32.0
>            Reporter: Stefan Egli
>            Priority: Minor
>
> As suggested by [~jsedding] in [this PR review comment|https://github.com/apache/jackrabbit-oak/pull/243#discussion_r462359594] the newly introduced (test method) {{DocumentNodeStore.stopBackgroundUpdateThread}} could be more elegantly implemented via a thread-factory approach. We should look into refactoring that code along those lines, if feasible extending the approach to the other background tasks too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)