You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by guozhangwang <gi...@git.apache.org> on 2017/11/13 19:02:14 UTC

[GitHub] kafka pull request #4208: MINOR: Not enough replica exception should never h...

GitHub user guozhangwang opened a pull request:

    https://github.com/apache/kafka/pull/4208

    MINOR: Not enough replica exception should never happen for delete records

    When reviewing https://github.com/apache/kafka/pull/4132, I felt that NOT_ENOUGH_REPLICAS should never happen actually. Hence proposing to remove it from the listed error code as well in the broker-side capture clause.
    
    Testing added in 4132 should have been sufficient.
    
    ### Committer Checklist (excluded from commit message)
    - [ ] Verify design and implementation 
    - [ ] Verify test coverage and CI build status
    - [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guozhangwang/kafka KMinor-delete-records-error-code

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4208
    
----
commit 86b8fe19fe551962bf5cf54c8c98b623972d6242
Author: Guozhang Wang <wa...@gmail.com>
Date:   2017-11-13T19:00:08Z

    Not enough replica exception should never happen for delete records

----


---

[GitHub] kafka pull request #4208: MINOR: Not enough replica exception should never h...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/4208


---