[jira] Commented: (DROIDS-51) review MultiThreadedTaskMaster thread creation/looping

["Mingfai Ma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DROIDS-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714100#action_12714100 ] 

Mingfai Ma commented on DROIDS-51:
----------------------------------

by reading the code (hasn't run it) and compare to the previous revision, it's good. it made some good improvements.

it doesn't seem to be easy to write unit test for this case. :-)

> review MultiThreadedTaskMaster thread creation/looping
> ------------------------------------------------------
>
>                 Key: DROIDS-51
>                 URL: https://issues.apache.org/jira/browse/DROIDS-51
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>            Reporter: Ryan McKinley
>         Attachments: DROIDS-51-MultiThreadedTaskMaster.patch
>
>
> Currently the MultiThreadedTaskMaster has a looping thread that then starts a new Thread for each task (and then that starts a new worker for each Task).
> This patch reworks this model so that:
>  * one thread makes sure there is a thread (runner) for each slot in the pool
>  * the runner starts new workers for each task and keeps going while there are more tasks to handle

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.