You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/05/28 23:18:36 UTC
[GitHub] [geode] pivotal-jbarrett opened a new pull request #6540: Adds some queue and map JMH benchmarks.
pivotal-jbarrett opened a new pull request #6540:
URL: https://github.com/apache/geode/pull/6540
Adds a JMH profiler for measuring the retained size specific objects.
Updates JHM to 1.32.
Adds some JMH benchmarks for testing certain data structures used internally in Geode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett merged pull request #6540: Adds some queue and map JMH benchmarks.
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett merged pull request #6540:
URL: https://github.com/apache/geode/pull/6540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] upthewaterspout commented on a change in pull request #6540: Adds some queue and map JMH benchmarks.
Posted by GitBox <gi...@apache.org>.
upthewaterspout commented on a change in pull request #6540:
URL: https://github.com/apache/geode/pull/6540#discussion_r649516824
##########
File path: geode-jmh/src/main/java/org/apache/geode/benchmark/jmh/profilers/ObjectSizeAgent.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.benchmark.jmh.profilers;
+
+import static java.lang.reflect.Modifier.isStatic;
+
+import java.lang.instrument.Instrumentation;
+import java.lang.reflect.Array;
+import java.lang.reflect.Field;
+import java.util.ArrayDeque;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.IdentityHashMap;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+public class ObjectSizeAgent {
Review comment:
This seems somewhat a duplicate of `ObjectGraphSizer` Did you check that out and see if you can use that instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #6540: Adds some queue and map JMH benchmarks.
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on a change in pull request #6540:
URL: https://github.com/apache/geode/pull/6540#discussion_r649560081
##########
File path: geode-jmh/src/main/java/org/apache/geode/benchmark/jmh/profilers/ObjectSizeAgent.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.benchmark.jmh.profilers;
+
+import static java.lang.reflect.Modifier.isStatic;
+
+import java.lang.instrument.Instrumentation;
+import java.lang.reflect.Array;
+import java.lang.reflect.Field;
+import java.util.ArrayDeque;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.IdentityHashMap;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+public class ObjectSizeAgent {
Review comment:
Don't really want geode-jmh to depend on geode-core. Is this a blocker for you? I could see moving the geode-core version out to its own module but that brings up split package issues and agent jar would change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #6540: Adds some queue and map JMH benchmarks.
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on pull request #6540:
URL: https://github.com/apache/geode/pull/6540#issuecomment-850729628
> This line of code ownership is adding many people
> `geode-core/**/org/apache/geode/internal/util/concurrent/** @nabarunnag @boglesby @kirklund`
Oh, yeah, that is pretty greedy and gobbles up jmh and jmhTest source sets. 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #6540: Adds some queue and map JMH benchmarks.
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on pull request #6540:
URL: https://github.com/apache/geode/pull/6540#issuecomment-850726142
This line of code ownership is adding many people
`geode-core/**/org/apache/geode/internal/util/concurrent/** @nabarunnag @boglesby @kirklund`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #6540: Adds some queue and map JMH benchmarks.
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on pull request #6540:
URL: https://github.com/apache/geode/pull/6540#issuecomment-850717258
This PR does not modify production or test code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org