You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "yzeng1618 (via GitHub)" <gi...@apache.org> on 2026/01/15 10:37:55 UTC
[PR] [Fix][Connector-V2][Databend] Ensure CDC final merge on committer close [seatunnel]
yzeng1618 opened a new pull request, #10349:
URL: https://github.com/apache/seatunnel/pull/10349
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
### Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
This PR fixes the flaky all-connectors-it-5 failure where DatabendCDCSinkIT sometimes needs multiple reruns to pass.
- Flaky CI evidence: https://github.com/yzeng1618/seatunnel-dev/actions/runs/20978819857 (reran 9 times before success, mainly failing in all-connectors-it-5)
- Related mitigation (not root cause): https://github.com/apache/seatunnel/pull/10269 increased timeout for DatabendCDCSinkIT, but longer waiting cannot help when the final CDC merge is never executed.
**Root cause**
- In CDC batch jobs, applying CDC changes to sink_table relies on merge execution timing (checkpoint/commit/close). In some runs the job finishes before the merge happens, leaving CDC raw records unmerged and sink_table empty/incorrect. Reruns may pass because a merge happens earlier, which explains the flakiness.
### Does this PR introduce _any_ user-facing change?
Yes. Bugfix: Databend CDC sink could finish without applying the final merge in some batch scenarios, causing missing/incorrect data in the target table.
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
-->
### How was this patch tested?
GitHub Actions: all-connectors-it-5 (JDK 8/11), including DatabendCDCSinkIT
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
-->
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
2. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in [label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in [seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector [plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Databend] Ensure CDC final merge on committer close [seatunnel]
Posted by "DanielCarter-stack (via GitHub)" <gi...@apache.org>.
DanielCarter-stack commented on PR #10349:
URL: https://github.com/apache/seatunnel/pull/10349#issuecomment-3759058650
<!-- code-pr-reviewer -->
Thanks for the contribution. A few issues to address:
**DatabendSinkAggregatedCommitter.java:257-258** - The outer `catch (SQLException e)` cannot catch `DatabendConnectorException` (a `RuntimeException`) from `performMerge()`. Remove or change to `Exception`.
**DatabendSinkAggregatedCommitter.java:141-144** - The `aggregatedCommitInfos` parameter in `performMerge()` is unused beyond the null check. Remove this unused parameter.
**DatabendSinkAggregatedCommitter.java:62** - The new `volatile boolean aborted` field lacks JavaDoc explaining its purpose and concurrent semantics.
**DatabendCDCSink.java:70-96** - The abort scenario is not tested. The E2E test only covers normal completion without validating the "checkpoint abort → abort() → close()" flow where the `aborted` flag prevents final merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Databend] Ensure CDC final merge on committer close [seatunnel]
Posted by "Carl-Zhou-CN (via GitHub)" <gi...@apache.org>.
Carl-Zhou-CN merged PR #10349:
URL: https://github.com/apache/seatunnel/pull/10349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Databend] Ensure CDC final merge on committer close [seatunnel]
Posted by "yzeng1618 (via GitHub)" <gi...@apache.org>.
yzeng1618 commented on PR #10349:
URL: https://github.com/apache/seatunnel/pull/10349#issuecomment-3758517133
> Thanks for the PR! Here are the blocking issues:
>
> **CRITICAL**
>
> * `DatabendSinkAggregatedCommitter.java:238-255` (close()) - **Resource leak risk**: If `performMerge()` throws an exception (line 243), the `connection.close()` on line 246 will never execute, leaking database connections. Consider wrapping `performMerge()` in its own try-catch within the outer try-finally to ensure cleanup runs.
>
> ```java
> try {
> if (!aborted && isCdcMode && connection != null && !connection.isClosed()) {
> try {
> log.info("[Instance {}] Performing final merge before closing", instanceId);
> performMerge(new ArrayList<>());
> } catch (Exception mergeEx) {
> log.error("[Instance {}] Final merge failed, will still close connection: {}",
> instanceId, mergeEx.getMessage(), mergeEx);
> }
> }
> } finally {
> // connection.close() here
> ```
>
> **HIGH**
>
> * `DatabendSinkAggregatedCommitter.java:62` (aborted) - **Concurrency hazard**: The `aborted` flag is a non-volatile boolean, but `abort()` and `close()` may be called concurrently (e.g., checkpoint failure triggers `abort()` while job end triggers `close()`). Use `volatile boolean` or `AtomicBoolean` to ensure visibility.
> * `DatabendSinkAggregatedCommitter.java:141-160` (performMerge) - **Misleading signature**: The method takes a `List<DatabendSinkAggregatedCommitInfo>` parameter but never uses it. This confuses the semantic (should merge "this batch" vs "all stream data"). Add null-check and JavaDoc clarifying the parameter is unused but retained for compatibility.
The repair has been completed as required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Databend] Ensure CDC final merge on committer close [seatunnel]
Posted by "zhangshenghang (via GitHub)" <gi...@apache.org>.
zhangshenghang commented on PR #10349:
URL: https://github.com/apache/seatunnel/pull/10349#issuecomment-3756852568
<!-- code-pr-reviewer -->
Thanks for the PR! Here are the blocking issues:
**CRITICAL**
- `DatabendSinkAggregatedCommitter.java:238-255` (close()) - **Resource leak risk**: If `performMerge()` throws an exception (line 243), the `connection.close()` on line 246 will never execute, leaking database connections. Consider wrapping `performMerge()` in its own try-catch within the outer try-finally to ensure cleanup runs.
```java
try {
if (!aborted && isCdcMode && connection != null && !connection.isClosed()) {
try {
log.info("[Instance {}] Performing final merge before closing", instanceId);
performMerge(new ArrayList<>());
} catch (Exception mergeEx) {
log.error("[Instance {}] Final merge failed, will still close connection: {}",
instanceId, mergeEx.getMessage(), mergeEx);
}
}
} finally {
// connection.close() here
```
**HIGH**
- `DatabendSinkAggregatedCommitter.java:62` (aborted) - **Concurrency hazard**: The `aborted` flag is a non-volatile boolean, but `abort()` and `close()` may be called concurrently (e.g., checkpoint failure triggers `abort()` while job end triggers `close()`). Use `volatile boolean` or `AtomicBoolean` to ensure visibility.
- `DatabendSinkAggregatedCommitter.java:141-160` (performMerge) - **Misleading signature**: The method takes a `List<DatabendSinkAggregatedCommitInfo>` parameter but never uses it. This confuses the semantic (should merge "this batch" vs "all stream data"). Add null-check and JavaDoc clarifying the parameter is unused but retained for compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org