You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/13 03:23:42 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null
cloud-fan commented on a change in pull request #33729:
URL: https://github.com/apache/spark/pull/33729#discussion_r688217565
##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -170,6 +170,21 @@ select
null - interval '2' year,
null + interval '2' hour,
null - interval '2' hour;
+select
Review comment:
there is a section at the beginning of this file `-- multiply and divide an interval by a number`. Can we put the null tests there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org