You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/06 06:13:50 UTC

[GitHub] [calcite] jinxing64 commented on a change in pull request #2000: [CALCITE-4040] An aggregate function that does not support roll up throws an exception when it is rolled up

jinxing64 commented on a change in pull request #2000:
URL: https://github.com/apache/calcite/pull/2000#discussion_r436242845



##########
File path: core/src/test/java/org/apache/calcite/test/MaterializedViewSubstitutionVisitorTest.java
##########
@@ -509,6 +509,21 @@
         .ok();
   }
 
+  /**
+   * stddev_pop aggregate function does not support roll up.
+   */
+  @Test public void testAggregateRollUp2() {

Review comment:
       `public` is not needed. Please remove.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org