You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/07 17:30:48 UTC
[GitHub] [beam] jrmccluskey opened a new pull request, #22187: Update Go BPG xlang documentation to include Java automated service start-up
jrmccluskey opened a new pull request, #22187:
URL: https://github.com/apache/beam/pull/22187
Calls out automated expansion service start-up workflow for Go, specifying how to use the automated start-up for Java and calling out that python expansion service start-up is not currently automated.
Fixes #22176
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #22187: Update Go BPG xlang documentation to include Java automated service start-up
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #22187:
URL: https://github.com/apache/beam/pull/22187#issuecomment-1178024923
> I'm debating changing the call-out to specifically mention the need for either a wrapped transform or to use the xlangx.UseAutomatedJavaExpansionService() function directly, definitely open to suggestions on it
Yeah, I think its worth adding a sentence in the middle that describes how to do this - as is, I still don't have enough context to know when/how I should be starting a Java expansion service. Other than that, this LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey merged pull request #22187: Update Go BPG xlang documentation to include Java automated service start-up
Posted by GitBox <gi...@apache.org>.
jrmccluskey merged PR #22187:
URL: https://github.com/apache/beam/pull/22187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #22187: Update Go BPG xlang documentation to include Java automated service start-up
Posted by GitBox <gi...@apache.org>.
jrmccluskey commented on PR #22187:
URL: https://github.com/apache/beam/pull/22187#issuecomment-1178016716
R: @damccorm @lostluck
I'm debating changing the call-out to specifically mention the need for either a wrapped transform or to use the `xlangx.UseAutomatedJavaExpansionService()` function directly, definitely open to suggestions on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org