You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/25 16:41:59 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request #11776: [Broker] Remove unnecessary futures; fix comment

michaeljmarshall opened a new pull request #11776:
URL: https://github.com/apache/pulsar/pull/11776


   ### Motivation
   
   In reading through the `ServerCnx` class, I noticed that there was some code that could be simplified. 
   
   ### Modifications
   
   * Remove unreachable log statements
   * Remove unnecessary future chaining
   * Fix comment
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   There are no changes to external behavior.
   
   ### Documentation
   
   #### For contributor
   
   For this PR, do we need to update docs?
   
   No. This change does not include any behavior changes, so the docs should stay the same.
   
   #### For committer
   
   For this PR, do we need to update docs?
   
   - If yes,
     
     - if you update docs in this PR, label this PR with the `doc` label.
     
     - if you plan to update docs later, label this PR with the `doc-required` label.
   
     - if you need help on updating docs, create a follow-up issue with the `doc-required` label.
     
   - If no, label this PR with the `no-need-doc` label and explain why.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #11776: [Broker] Remove unnecessary futures; fix comment

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #11776:
URL: https://github.com/apache/pulsar/pull/11776


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org