You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by je...@apache.org on 2014/09/01 23:08:33 UTC
git commit: THRIFT-2666 Usage of PYTHONHASHSEED breaks older Python
code Client: Python Patch: Jens Geyer
Repository: thrift
Updated Branches:
refs/heads/master e26a19bba -> d0bd17e72
THRIFT-2666 Usage of PYTHONHASHSEED breaks older Python code
Client: Python
Patch: Jens Geyer
Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/d0bd17e7
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/d0bd17e7
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/d0bd17e7
Branch: refs/heads/master
Commit: d0bd17e7263cb8f92c21d3e1dad2ee5b5e9f79e5
Parents: e26a19b
Author: Jens Geyer <je...@apache.org>
Authored: Mon Sep 1 23:05:08 2014 +0200
Committer: Jens Geyer <je...@apache.org>
Committed: Mon Sep 1 23:05:08 2014 +0200
----------------------------------------------------------------------
compiler/cpp/src/generate/t_py_generator.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/thrift/blob/d0bd17e7/compiler/cpp/src/generate/t_py_generator.cc
----------------------------------------------------------------------
diff --git a/compiler/cpp/src/generate/t_py_generator.cc b/compiler/cpp/src/generate/t_py_generator.cc
index 5ac92c3..f0c31a4 100644
--- a/compiler/cpp/src/generate/t_py_generator.cc
+++ b/compiler/cpp/src/generate/t_py_generator.cc
@@ -787,7 +787,7 @@ void t_py_generator::generate_py_struct_definition(ofstream& out,
out << indent() << "def __hash__(self):" << endl;
indent_up();
- indent(out) << "value = PYTHONHASHSEED" << endl;
+ indent(out) << "value = 17" << endl; // PYTHONHASHSEED would be better, but requires Python 3.2.3
for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) {
indent(out) << "value = (value * 31) ^ hash(self." << (*m_iter)->get_name() + ")" << endl;
}