[jira] [Commented] (YARN-9444) YARN API ResourceUtils's getRequestedResourcesFromConfig doesn't recognize yarn.io/gpu as a valid resource

["Gergely Pollak (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979404#comment-16979404 ] 

Gergely Pollak commented on YARN-9444:
--------------------------------------

Thank you [~snemeth] for the feedback, I've changed the testcase according to your suggestions, however the hamcrest-library wasn't available in the project, and I didn't want to add it just for this case, also I don't think it would have been helpful, since the elements of the returning list are not simple Strings, but ResourceInformation objects, so it would have been quite a hassle to create a ResourceInformation list manually just to use the containsInAnyOrder method, I've just implemented this check with a regular loop and a hashset.

> YARN API ResourceUtils's getRequestedResourcesFromConfig doesn't recognize yarn.io/gpu as a valid resource
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-9444
>                 URL: https://issues.apache.org/jira/browse/YARN-9444
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: api
>            Reporter: Gergely Pollak
>            Assignee: Gergely Pollak
>            Priority: Minor
>         Attachments: YARN-9444.001.patch, YARN-9444.002.patch
>
>
> The original issue was the jobclient test did not send the requested resource type, when specified in the command line eg:
> {code:java}
> hadoop jar hadoop-mapreduce-client-jobclient-tests.jar sleep -Dmapreduce.reduce.resource.yarn.io/gpu=1  -m 10 -r 1 -mt 90000
> {code}
> After some investigation, it turned out it only affects resource types with name containing '.' characters. And the root cause is regexp from the getRequestedResourcesFromConfig method.
> {code:java}
> "^" + Pattern.quote(prefix) + "[^.]+$"
> {code}
> This regexp explicitly forbids any dots in the resource type name, which is inconsistent with the default resource type for gpu and fpga, which are yarn.io/gpu and yarn.io/fpga respectively.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org