You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/16 22:21:59 UTC

[jira] [Commented] (CXF-7140) Multiple calls to AsyncResponse.cancel() returns different values

    [ https://issues.apache.org/jira/browse/CXF-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671853#comment-15671853 ] 

ASF GitHub Bot commented on CXF-7140:
-------------------------------------

GitHub user andymc12 opened a pull request:

    https://github.com/apache/cxf/pull/202

    CXF-7140: Ensure AsyncResponse.cancel(...) behaves the same when invoked twice.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andymc12/cxf asyncRespTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cxf/pull/202.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #202
    
----
commit 03ff5c7419ee48ded3a7ce5155186263efb46ce0
Author: andymc12 <j....@gmail.com>
Date:   2016-11-16T22:05:40Z

    Ensure AsyncResponse.cancel(...) behaves the same when invoked twice.

----


> Multiple calls to AsyncResponse.cancel() returns different values
> -----------------------------------------------------------------
>
>                 Key: CXF-7140
>                 URL: https://issues.apache.org/jira/browse/CXF-7140
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 3.1.8
>            Reporter: Andy McCright
>
> When we incorporated CXF 3.1.8 into our builds, our CTS testing team found some failures related to the AsyncResponse.cancel(...) methods.  According to the spec, once the AsyncResponse has been canceled, subsequent calls to cancel should return true.
> It looks like one of the changes in CXF-7037 changed the order of things in the doCancel method -- and those changes result in false getting returned when calling cancel(...) a second time.
> I have written some tests that demonstrate the expected CTS behavior - and they fail with the current code, but pass when reverting the order change in doCancel().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)