You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kevin Wilfong (Created) (JIRA)" <ji...@apache.org> on 2012/04/18 01:52:17 UTC
[jira] [Created] (HIVE-2960) Stop testing concat of partitions
containing control characters.
Stop testing concat of partitions containing control characters.
----------------------------------------------------------------
Key: HIVE-2960
URL: https://issues.apache.org/jira/browse/HIVE-2960
Project: Hive
Issue Type: Test
Reporter: Kevin Wilfong
Assignee: Kevin Wilfong
We have been, for a short while, testing to make sure that concatenation commands work with partitions that contain ASCII control characters. This happened to work up until recently due to a happy coincidence in the way the Hive object's HiveConf was updated. Namely, it was updated often enough that it got configs set by the user, but not so often that it got the value for hive.query.string. With some recent changes, it now needs to be updated more often, see https://issues.apache.org/jira/browse/HIVE-2918
This breaks the process of launching a job to merge partitions that contain ASCII control characters. The job conf is constructed using the updated Hive conf containing the value of hive.query.string which contains ASCII control characters. When the job conf is converted to XML it fails because these characters are illegal. Given that any query has, even prior to this change, failed when that query contained ASCII control characters, and hence these partitions cannot be queried directly, it seems reasonable to no longer support concatenating them either (which this change will allow for).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2960) Stop testing concat of partitions
containing control characters.
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2960:
--------------------------------
Attachment: escape2.q.out
> Stop testing concat of partitions containing control characters.
> ----------------------------------------------------------------
>
> Key: HIVE-2960
> URL: https://issues.apache.org/jira/browse/HIVE-2960
> Project: Hive
> Issue Type: Test
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2960.D2865.1.patch, escape2.q.out
>
>
> We have been, for a short while, testing to make sure that concatenation commands work with partitions that contain ASCII control characters. This happened to work up until recently due to a happy coincidence in the way the Hive object's HiveConf was updated. Namely, it was updated often enough that it got configs set by the user, but not so often that it got the value for hive.query.string. With some recent changes, it now needs to be updated more often, see https://issues.apache.org/jira/browse/HIVE-2918
> This breaks the process of launching a job to merge partitions that contain ASCII control characters. The job conf is constructed using the updated Hive conf containing the value of hive.query.string which contains ASCII control characters. When the job conf is converted to XML it fails because these characters are illegal. Given that any query has, even prior to this change, failed when that query contained ASCII control characters, and hence these partitions cannot be queried directly, it seems reasonable to no longer support concatenating them either (which this change will allow for).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2960) Stop testing concat of partitions
containing control characters.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261343#comment-13261343 ]
Hudson commented on HIVE-2960:
------------------------------
Integrated in Hive-trunk-h0.21 #1395 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1395/])
HIVE-2960 Stop testing concat of partitions containing control characters.
(Kevin Wilfong via namit) (Revision 1330057)
Result = FAILURE
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330057
Files :
* /hive/trunk/ql/src/test/queries/clientpositive/escape2.q
* /hive/trunk/ql/src/test/results/clientpositive/escape2.q.out
> Stop testing concat of partitions containing control characters.
> ----------------------------------------------------------------
>
> Key: HIVE-2960
> URL: https://issues.apache.org/jira/browse/HIVE-2960
> Project: Hive
> Issue Type: Test
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Fix For: 0.10.0
>
> Attachments: HIVE-2960.D2865.1.patch, escape2.q.out
>
>
> We have been, for a short while, testing to make sure that concatenation commands work with partitions that contain ASCII control characters. This happened to work up until recently due to a happy coincidence in the way the Hive object's HiveConf was updated. Namely, it was updated often enough that it got configs set by the user, but not so often that it got the value for hive.query.string. With some recent changes, it now needs to be updated more often, see https://issues.apache.org/jira/browse/HIVE-2918
> This breaks the process of launching a job to merge partitions that contain ASCII control characters. The job conf is constructed using the updated Hive conf containing the value of hive.query.string which contains ASCII control characters. When the job conf is converted to XML it fails because these characters are illegal. Given that any query has, even prior to this change, failed when that query contained ASCII control characters, and hence these partitions cannot be queried directly, it seems reasonable to no longer support concatenating them either (which this change will allow for).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2960) Stop testing concat of partitions
containing control characters.
Posted by "Kevin Wilfong (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256078#comment-13256078 ]
Kevin Wilfong commented on HIVE-2960:
-------------------------------------
Attached escape2.q.out because the diff for some reason thought it was a binary file.
> Stop testing concat of partitions containing control characters.
> ----------------------------------------------------------------
>
> Key: HIVE-2960
> URL: https://issues.apache.org/jira/browse/HIVE-2960
> Project: Hive
> Issue Type: Test
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2960.D2865.1.patch, escape2.q.out
>
>
> We have been, for a short while, testing to make sure that concatenation commands work with partitions that contain ASCII control characters. This happened to work up until recently due to a happy coincidence in the way the Hive object's HiveConf was updated. Namely, it was updated often enough that it got configs set by the user, but not so often that it got the value for hive.query.string. With some recent changes, it now needs to be updated more often, see https://issues.apache.org/jira/browse/HIVE-2918
> This breaks the process of launching a job to merge partitions that contain ASCII control characters. The job conf is constructed using the updated Hive conf containing the value of hive.query.string which contains ASCII control characters. When the job conf is converted to XML it fails because these characters are illegal. Given that any query has, even prior to this change, failed when that query contained ASCII control characters, and hence these partitions cannot be queried directly, it seems reasonable to no longer support concatenating them either (which this change will allow for).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2960) Stop testing concat of partitions
containing control characters.
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2960:
-----------------------------------
Fix Version/s: 0.10.0
> Stop testing concat of partitions containing control characters.
> ----------------------------------------------------------------
>
> Key: HIVE-2960
> URL: https://issues.apache.org/jira/browse/HIVE-2960
> Project: Hive
> Issue Type: Test
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Fix For: 0.10.0
>
> Attachments: HIVE-2960.D2865.1.patch, escape2.q.out
>
>
> We have been, for a short while, testing to make sure that concatenation commands work with partitions that contain ASCII control characters. This happened to work up until recently due to a happy coincidence in the way the Hive object's HiveConf was updated. Namely, it was updated often enough that it got configs set by the user, but not so often that it got the value for hive.query.string. With some recent changes, it now needs to be updated more often, see https://issues.apache.org/jira/browse/HIVE-2918
> This breaks the process of launching a job to merge partitions that contain ASCII control characters. The job conf is constructed using the updated Hive conf containing the value of hive.query.string which contains ASCII control characters. When the job conf is converted to XML it fails because these characters are illegal. Given that any query has, even prior to this change, failed when that query contained ASCII control characters, and hence these partitions cannot be queried directly, it seems reasonable to no longer support concatenating them either (which this change will allow for).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2960) Stop testing concat of partitions
containing control characters.
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2960:
------------------------------
Attachment: HIVE-2960.D2865.1.patch
kevinwilfong requested code review of "HIVE-2960 [jira] Stop testing concat of partitions containing control characters.".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2960
Remove the testcases for concatenating partitions containing control characters.
We have been, for a short while, testing to make sure that concatenation commands work with partitions that contain ASCII control characters. This happened to work up until recently due to a happy coincidence in the way the Hive object's HiveConf was updated. Namely, it was updated often enough that it got configs set by the user, but not so often that it got the value for hive.query.string. With some recent changes, it now needs to be updated more often, see https://issues.apache.org/jira/browse/HIVE-2918
This breaks the process of launching a job to merge partitions that contain ASCII control characters. The job conf is constructed using the updated Hive conf containing the value of hive.query.string which contains ASCII control characters. When the job conf is converted to XML it fails because these characters are illegal. Given that any query has, even prior to this change, failed when that query contained ASCII control characters, and hence these partitions cannot be queried directly, it seems reasonable to no longer support concatenating them either (which this change will allow for).
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2865
AFFECTED FILES
ql/src/test/results/clientpositive/escape2.q.out
ql/src/test/queries/clientpositive/escape2.q
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/6501/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Stop testing concat of partitions containing control characters.
> ----------------------------------------------------------------
>
> Key: HIVE-2960
> URL: https://issues.apache.org/jira/browse/HIVE-2960
> Project: Hive
> Issue Type: Test
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2960.D2865.1.patch
>
>
> We have been, for a short while, testing to make sure that concatenation commands work with partitions that contain ASCII control characters. This happened to work up until recently due to a happy coincidence in the way the Hive object's HiveConf was updated. Namely, it was updated often enough that it got configs set by the user, but not so often that it got the value for hive.query.string. With some recent changes, it now needs to be updated more often, see https://issues.apache.org/jira/browse/HIVE-2918
> This breaks the process of launching a job to merge partitions that contain ASCII control characters. The job conf is constructed using the updated Hive conf containing the value of hive.query.string which contains ASCII control characters. When the job conf is converted to XML it fails because these characters are illegal. Given that any query has, even prior to this change, failed when that query contained ASCII control characters, and hence these partitions cannot be queried directly, it seems reasonable to no longer support concatenating them either (which this change will allow for).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HIVE-2960) Stop testing concat of partitions
containing control characters.
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain resolved HIVE-2960.
------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Committed. Thanks Kevin
> Stop testing concat of partitions containing control characters.
> ----------------------------------------------------------------
>
> Key: HIVE-2960
> URL: https://issues.apache.org/jira/browse/HIVE-2960
> Project: Hive
> Issue Type: Test
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2960.D2865.1.patch, escape2.q.out
>
>
> We have been, for a short while, testing to make sure that concatenation commands work with partitions that contain ASCII control characters. This happened to work up until recently due to a happy coincidence in the way the Hive object's HiveConf was updated. Namely, it was updated often enough that it got configs set by the user, but not so often that it got the value for hive.query.string. With some recent changes, it now needs to be updated more often, see https://issues.apache.org/jira/browse/HIVE-2918
> This breaks the process of launching a job to merge partitions that contain ASCII control characters. The job conf is constructed using the updated Hive conf containing the value of hive.query.string which contains ASCII control characters. When the job conf is converted to XML it fails because these characters are illegal. Given that any query has, even prior to this change, failed when that query contained ASCII control characters, and hence these partitions cannot be queried directly, it seems reasonable to no longer support concatenating them either (which this change will allow for).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira