[jira] [Comment Edited] (HBASE-16234) Expect and handle nulls when assigning replicas

["Heng Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397032#comment-15397032 ] 

Heng Chen edited comment on HBASE-16234 at 7/28/16 6:47 AM:
------------------------------------------------------------

{code}
+        HTableDescriptor htd = master.getTableDescriptors().get(table);
+        if (htd == null) {
+          LOG.warn("master can not get TableDescriptor from table '" + table);
+        } else {
+          desiredRegionReplication = htd.getRegionReplication();
+        }
{code}

If htd is null, why not continue the loop?  wdyt?


was (Author: chenheng):
{quote}
+        HTableDescriptor htd = master.getTableDescriptors().get(table);
+        if (htd == null) {
+          LOG.warn("master can not get TableDescriptor from table '" + table);
+        } else {
+          desiredRegionReplication = htd.getRegionReplication();
+        }
{quote}

If htd is null, why not continue the loop?  wdyt?

> Expect and handle nulls when assigning replicas
> -----------------------------------------------
>
>                 Key: HBASE-16234
>                 URL: https://issues.apache.org/jira/browse/HBASE-16234
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment
>    Affects Versions: 2.0.0
>            Reporter: Harsh J
>            Assignee: Yi Liang
>         Attachments: HBASE-16234-V1.patch, HBASE-16234-V1.patch, HBASE-16234-V2.patch, HBASE-16234-V3.patch
>
>
> Observed this on a cluster:
> {code}
> FATAL org.apache.hadoop.hbase.master.HMaster: Unhandled exception. Starting shutdown. 
> java.lang.NullPointerException 
> at org.apache.hadoop.hbase.master.AssignmentManager.replicaRegionsNotRecordedInMeta(AssignmentManager.java:2799) 
> at org.apache.hadoop.hbase.master.AssignmentManager.assignAllUserRegions(AssignmentManager.java:2778) 
> at org.apache.hadoop.hbase.master.AssignmentManager.processDeadServersAndRegionsInTransition(AssignmentManager.java:638) 
> at org.apache.hadoop.hbase.master.AssignmentManager.joinCluster(AssignmentManager.java:485) 
> at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:723) 
> at org.apache.hadoop.hbase.master.HMaster.access$500(HMaster.java:169) 
> at org.apache.hadoop.hbase.master.HMaster$1.run(HMaster.java:1481) 
> at java.lang.Thread.run(Thread.java:745) 
> {code}
> It looks like {{FSTableDescriptors#get(…)}} can be expected to return null in some cases, but {{AssignmentManager.replicaRegionsNotRecordedInMeta(…)}} does not currently have any handling for such a possibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)