You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Benedict (JIRA)" <ji...@apache.org> on 2015/08/05 10:30:04 UTC
[jira] [Commented] (CASSANDRA-9986) Remove
SliceableUnfilteredRowIterator
[ https://issues.apache.org/jira/browse/CASSANDRA-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655007#comment-14655007 ]
Benedict commented on CASSANDRA-9986:
-------------------------------------
Unassigning, in case somebody else wants to take this before I have time.
> Remove SliceableUnfilteredRowIterator
> -------------------------------------
>
> Key: CASSANDRA-9986
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9986
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Benedict
> Priority: Minor
> Fix For: 3.0.x
>
>
> After CASSANDRA-9932, there is only one instance where this class is needed, and that is {{SSTableIterator}}. It would be much simpler if, like in {{AbstractBTreePartition}}, the slices were passed into the {{SSTableIterator}} on construction. This would make the control flow easier to follow both:
> * logically, because:
> ** memtables and sstables would have the same access pattern; and
> ** our SSTableIterator would not have two modes of (parallel) operation, which is kind of confusing (the slices are independent of the non-sliced iteration)
> * in the debugger, because we would have one fewer wrapping iterator
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)