You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/23 12:13:08 UTC
[GitHub] [spark] MaxGekk opened a new pull request #35951: [WIP][SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
MaxGekk opened a new pull request #35951:
URL: https://github.com/apache/spark/pull/35951
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
By running new tests:
```
$ build/sbt "sql/test:testOnly org.apache.spark.sql.expressions.ExpressionInfoSuite"
$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z timestamp-ltz.sql"
$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z timestamp-ntz.sql"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #35951: [WIP][SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #35951:
URL: https://github.com/apache/spark/pull/35951#discussion_r833334174
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -3002,14 +3002,17 @@ object SubtractDates {
usage = "_FUNC_(sourceTz, targetTz, sourceTs) - Converts the timestamp without time zone `sourceTs` from the `sourceTz` time zone to `targetTz`. ",
arguments = """
Arguments:
- * sourceTz - the time zone for the input timestamp
+ * sourceTz - the time zone for the input timestamp.
+ If it is missed, the current session time zone is used as the source time zone.
Review comment:
Could you explain why do you think it is weird, and what kind of issues do you see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #35951: [SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #35951:
URL: https://github.com/apache/spark/pull/35951#discussion_r834000160
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -2999,17 +2999,20 @@ object SubtractDates {
// scalastyle:off line.size.limit
@ExpressionDescription(
- usage = "_FUNC_(sourceTz, targetTz, sourceTs) - Converts the timestamp without time zone `sourceTs` from the `sourceTz` time zone to `targetTz`. ",
+ usage = "_FUNC_([sourceTz, ]targetTz, sourceTs) - Converts the timestamp without time zone `sourceTs` from the `sourceTz` time zone to `targetTz`. ",
arguments = """
Arguments:
- * sourceTz - the time zone for the input timestamp
+ * sourceTz - the time zone for the input timestamp.
+ If it is missed, the current session time zone is used as the source time zone.
* targetTz - the time zone to which the input timestamp should be converted
* sourceTs - a timestamp without time zone
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #35951: [SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #35951:
URL: https://github.com/apache/spark/pull/35951#discussion_r833457891
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -3002,14 +3002,17 @@ object SubtractDates {
usage = "_FUNC_(sourceTz, targetTz, sourceTs) - Converts the timestamp without time zone `sourceTs` from the `sourceTz` time zone to `targetTz`. ",
arguments = """
Arguments:
- * sourceTz - the time zone for the input timestamp
+ * sourceTz - the time zone for the input timestamp.
+ If it is missed, the current session time zone is used as the source time zone.
Review comment:
I see, then adding a new constructor LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35951: [WIP][SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35951:
URL: https://github.com/apache/spark/pull/35951#issuecomment-1076309543
The PR addresses the comment https://github.com/apache/spark/pull/34896#discussion_r769366147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #35951: [SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #35951:
URL: https://github.com/apache/spark/pull/35951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk removed a comment on pull request #35951: [WIP][SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
MaxGekk removed a comment on pull request #35951:
URL: https://github.com/apache/spark/pull/35951#issuecomment-1076309543
The PR addresses the comment https://github.com/apache/spark/pull/34896#discussion_r769366147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #35951: [WIP][SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #35951:
URL: https://github.com/apache/spark/pull/35951#discussion_r833334174
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -3002,14 +3002,17 @@ object SubtractDates {
usage = "_FUNC_(sourceTz, targetTz, sourceTs) - Converts the timestamp without time zone `sourceTs` from the `sourceTz` time zone to `targetTz`. ",
arguments = """
Arguments:
- * sourceTz - the time zone for the input timestamp
+ * sourceTz - the time zone for the input timestamp.
+ If it is missed, the current session time zone is used as the source time zone.
Review comment:
Could you explain why do you think it is weird, and what kind of issues do you see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35951: [SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35951:
URL: https://github.com/apache/spark/pull/35951#issuecomment-1077270928
@cloud-fan @HyukjinKwon @gengliangwang Could you review this PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #35951: [SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #35951:
URL: https://github.com/apache/spark/pull/35951#discussion_r833977584
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -2999,17 +2999,20 @@ object SubtractDates {
// scalastyle:off line.size.limit
@ExpressionDescription(
- usage = "_FUNC_(sourceTz, targetTz, sourceTs) - Converts the timestamp without time zone `sourceTs` from the `sourceTz` time zone to `targetTz`. ",
+ usage = "_FUNC_([sourceTz, ]targetTz, sourceTs) - Converts the timestamp without time zone `sourceTs` from the `sourceTz` time zone to `targetTz`. ",
arguments = """
Arguments:
- * sourceTz - the time zone for the input timestamp
+ * sourceTz - the time zone for the input timestamp.
+ If it is missed, the current session time zone is used as the source time zone.
* targetTz - the time zone to which the input timestamp should be converted
* sourceTs - a timestamp without time zone
Review comment:
I think such implicit cast is out of scope of the expression otherwise we have to mention all possible casts like from string, date, timestamp_ltz and etc. and do that for all expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #35951: [WIP][SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #35951:
URL: https://github.com/apache/spark/pull/35951#discussion_r833337705
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -3002,14 +3002,17 @@ object SubtractDates {
usage = "_FUNC_(sourceTz, targetTz, sourceTs) - Converts the timestamp without time zone `sourceTs` from the `sourceTz` time zone to `targetTz`. ",
arguments = """
Arguments:
- * sourceTz - the time zone for the input timestamp
+ * sourceTz - the time zone for the input timestamp.
+ If it is missed, the current session time zone is used as the source time zone.
Review comment:
The main goal of the changes is to help users in migrations from other systems to Spark SQL easier. Other systems support optional first parameter:
- https://docs.aws.amazon.com/redshift/latest/dg/CONVERT_TIMEZONE.html
- https://docs.snowflake.com/en/sql-reference/functions/convert_timezone.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #35951: [WIP][SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #35951:
URL: https://github.com/apache/spark/pull/35951#discussion_r833289239
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -3002,14 +3002,17 @@ object SubtractDates {
usage = "_FUNC_(sourceTz, targetTz, sourceTs) - Converts the timestamp without time zone `sourceTs` from the `sourceTz` time zone to `targetTz`. ",
arguments = """
Arguments:
- * sourceTz - the time zone for the input timestamp
+ * sourceTz - the time zone for the input timestamp.
+ If it is missed, the current session time zone is used as the source time zone.
Review comment:
We don't have by-name parameters in SQL functions yet, and it's weird that the non-last parameter can be optional...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35951: [SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35951:
URL: https://github.com/apache/spark/pull/35951#issuecomment-1077281484
@gengliangwang I added a check to timestamp-ltz.sql especially to test the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35951: [SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35951:
URL: https://github.com/apache/spark/pull/35951#issuecomment-1077337629
Merging to master. Thank you, @gengliangwang and @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35951: [WIP][SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35951:
URL: https://github.com/apache/spark/pull/35951#issuecomment-1076391626
This is an alternative solution for https://github.com/apache/spark/pull/34896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #35951: [WIP][SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #35951:
URL: https://github.com/apache/spark/pull/35951#discussion_r833337705
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -3002,14 +3002,17 @@ object SubtractDates {
usage = "_FUNC_(sourceTz, targetTz, sourceTs) - Converts the timestamp without time zone `sourceTs` from the `sourceTz` time zone to `targetTz`. ",
arguments = """
Arguments:
- * sourceTz - the time zone for the input timestamp
+ * sourceTz - the time zone for the input timestamp.
+ If it is missed, the current session time zone is used as the source time zone.
Review comment:
What kind of issues do you see? BTW, the main goal of the changes is to help users in migrations from other systems to Spark SQL easier. Other systems support optional first parameter:
- https://docs.aws.amazon.com/redshift/latest/dg/CONVERT_TIMEZONE.html
- https://docs.snowflake.com/en/sql-reference/functions/convert_timezone.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #35951: [SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #35951:
URL: https://github.com/apache/spark/pull/35951#issuecomment-1077279601
If source tz is missing, can the source_timestamp be timestamp_ltz?
Snowflake supports such case: https://docs.snowflake.com/en/sql-reference/functions/convert_timezone.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #35951: [SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #35951:
URL: https://github.com/apache/spark/pull/35951#discussion_r833961223
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -2999,17 +2999,20 @@ object SubtractDates {
// scalastyle:off line.size.limit
@ExpressionDescription(
- usage = "_FUNC_(sourceTz, targetTz, sourceTs) - Converts the timestamp without time zone `sourceTs` from the `sourceTz` time zone to `targetTz`. ",
+ usage = "_FUNC_([sourceTz, ]targetTz, sourceTs) - Converts the timestamp without time zone `sourceTs` from the `sourceTz` time zone to `targetTz`. ",
arguments = """
Arguments:
- * sourceTz - the time zone for the input timestamp
+ * sourceTz - the time zone for the input timestamp.
+ If it is missed, the current session time zone is used as the source time zone.
* targetTz - the time zone to which the input timestamp should be converted
* sourceTs - a timestamp without time zone
Review comment:
Shall we update the description of `sourceTs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org