You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by Randall Leeds <ra...@gmail.com> on 2011/11/10 02:01:29 UTC

Re: git commit: fix improper comparison on filtered changes

Thanks, Filipe.

On Wed, Nov 9, 2011 at 16:59,  <fd...@apache.org> wrote:
> Updated Branches:
>  refs/heads/1.2.x 22d798888 -> 27ce101a3
>
>
> fix improper comparison on filtered changes
>
> Regression caught by the changes js test.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo
> Commit: http://git-wip-us.apache.org/repos/asf/couchdb/commit/27ce101a
> Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/27ce101a
> Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/27ce101a
>
> Branch: refs/heads/1.2.x
> Commit: 27ce101a3223e2c311b82654caed6363d1fd7288
> Parents: 22d7988
> Author: Randall Leeds <ra...@apache.org>
> Authored: Wed Nov 9 01:16:36 2011 -0800
> Committer: Filipe David Borba Manana <fd...@apache.org>
> Committed: Thu Nov 10 00:12:24 2011 +0000
>
> ----------------------------------------------------------------------
>  src/couchdb/couch_changes.erl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/couchdb/blob/27ce101a/src/couchdb/couch_changes.erl
> ----------------------------------------------------------------------
> diff --git a/src/couchdb/couch_changes.erl b/src/couchdb/couch_changes.erl
> index ee05817..bcfaaf0 100644
> --- a/src/couchdb/couch_changes.erl
> +++ b/src/couchdb/couch_changes.erl
> @@ -328,7 +328,7 @@ send_lookup_changes(FullDocInfos, StartSeq, Dir, Db, Fun, Acc0) ->
>     end,
>     GreaterFun = case Dir of
>     fwd ->
> -        fun(A, B) -> A >= B end;
> +        fun(A, B) -> A > B end;
>     rev ->
>         fun(A, B) -> A =< B end
>     end,
>
>