You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2021/02/24 00:05:20 UTC

[GitHub] [madlib] kaknikhil opened a new pull request #552: DL: Remove with clause while running tf operations

kaknikhil opened a new pull request #552:
URL: https://github.com/apache/madlib/pull/552


   JIRA: MADLIB-1467
   
   We noticed that we run tf operations like `model.fit` on gpu device
   using `with tf.device(/gpu:0):`. It turns out that some of the
   operations(like passing class_weight as a fit param) may not be fully
   supported on gpus. Since we already set `CUDA_VISIBLE_DEVICES` env
   variable, we don't explicitly need to use the with clause to force the
   operation to be run on gpus. So to fix this issue, this commit removes all
   the with clauses so that operations are allowed to run on cpu as well.
   
   Co-authored-by: Ekta Khanna <ek...@vmware.com>
   
   <!--  
   
   Thanks for sending a pull request!  Here are some tips for you:
   1. Refer to this link for contribution guidelines https://cwiki.apache.org/confluence/display/MADLIB/Contribution+Guidelines
   2. Please Provide the Module Name, a JIRA Number and a short description about your changes.
   -->
   
   - [ ] Add the module name, JIRA# to PR/commit and description.
   - [ ] Add tests for the change. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [madlib] kaknikhil merged pull request #552: DL: Remove with clause while running tf operations

Posted by GitBox <gi...@apache.org>.
kaknikhil merged pull request #552:
URL: https://github.com/apache/madlib/pull/552


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org