You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/04/07 03:27:01 UTC
Review Request 58252: Allowed the local authorizer to accept subjects
with no value.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58252/
-----------------------------------------------------------
Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7014
https://issues.apache.org/jira/browse/MESOS-7014
Repository: mesos
Description
-------
This patch updates checks in the local authorizer to allow subjects
which specify `claims` instead of a `value`.
Diffs
-----
src/authorizer/local/authorizer.cpp e241edf4afa48d35dbbbb94d72e8e8690f5bedfc
Diff: https://reviews.apache.org/r/58252/diff/1/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 58252: Allowed the local authorizer to accept
subjects with no value.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58252/#review171707
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On April 8, 2017, 1:15 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58252/
> -----------------------------------------------------------
>
> (Updated April 8, 2017, 1:15 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7014
> https://issues.apache.org/jira/browse/MESOS-7014
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates checks in the local authorizer to allow subjects
> which specify `claims` instead of a `value`.
>
>
> Diffs
> -----
>
> src/authorizer/local/authorizer.cpp e241edf4afa48d35dbbbb94d72e8e8690f5bedfc
>
>
> Diff: https://reviews.apache.org/r/58252/diff/2/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58252: Allowed the local authorizer to accept
subjects with no value.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58252/#review171525
-----------------------------------------------------------
LGTM. Just get rid of the unnecessary parentheses.
src/authorizer/local/authorizer.cpp
Line 1091 (original), 1091 (patched)
<https://reviews.apache.org/r/58252/#comment244475>
No reason for the extra parentheses around this pair anymore either. Why not:
```
CHECK(!request.has_subject() ||
request.subject().has_value() ||
request.subject().has_claims());
```
- Adam B
On April 7, 2017, 4:15 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58252/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 4:15 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7014
> https://issues.apache.org/jira/browse/MESOS-7014
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates checks in the local authorizer to allow subjects
> which specify `claims` instead of a `value`.
>
>
> Diffs
> -----
>
> src/authorizer/local/authorizer.cpp e241edf4afa48d35dbbbb94d72e8e8690f5bedfc
>
>
> Diff: https://reviews.apache.org/r/58252/diff/2/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58252: Allowed the local authorizer to accept
subjects with no value.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58252/#review171478
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 7, 2017, 11:15 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58252/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 11:15 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7014
> https://issues.apache.org/jira/browse/MESOS-7014
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates checks in the local authorizer to allow subjects
> which specify `claims` instead of a `value`.
>
>
> Diffs
> -----
>
> src/authorizer/local/authorizer.cpp e241edf4afa48d35dbbbb94d72e8e8690f5bedfc
>
>
> Diff: https://reviews.apache.org/r/58252/diff/2/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58252: Allowed the local authorizer to accept
subjects with no value.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58252/
-----------------------------------------------------------
(Updated April 13, 2017, 6:05 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7014
https://issues.apache.org/jira/browse/MESOS-7014
Repository: mesos
Description
-------
This patch updates checks in the local authorizer to allow subjects
which specify `claims` instead of a `value`.
Diffs (updated)
-----
src/authorizer/local/authorizer.cpp 1c1f912794cfe61112a0e513b217ba3a755f35f1
Diff: https://reviews.apache.org/r/58252/diff/4/
Changes: https://reviews.apache.org/r/58252/diff/3-4/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 58252: Allowed the local authorizer to accept
subjects with no value.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58252/
-----------------------------------------------------------
(Updated April 12, 2017, 4:40 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7014
https://issues.apache.org/jira/browse/MESOS-7014
Repository: mesos
Description
-------
This patch updates checks in the local authorizer to allow subjects
which specify `claims` instead of a `value`.
Diffs (updated)
-----
src/authorizer/local/authorizer.cpp 1c1f912794cfe61112a0e513b217ba3a755f35f1
Diff: https://reviews.apache.org/r/58252/diff/3/
Changes: https://reviews.apache.org/r/58252/diff/2-3/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 58252: Allowed the local authorizer to accept
subjects with no value.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58252/
-----------------------------------------------------------
(Updated April 7, 2017, 11:15 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7014
https://issues.apache.org/jira/browse/MESOS-7014
Repository: mesos
Description
-------
This patch updates checks in the local authorizer to allow subjects
which specify `claims` instead of a `value`.
Diffs (updated)
-----
src/authorizer/local/authorizer.cpp e241edf4afa48d35dbbbb94d72e8e8690f5bedfc
Diff: https://reviews.apache.org/r/58252/diff/2/
Changes: https://reviews.apache.org/r/58252/diff/1-2/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 58252: Allowed the local authorizer to accept
subjects with no value.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58252/#review171317
-----------------------------------------------------------
src/authorizer/local/authorizer.cpp
Line 1091 (original), 1091 (patched)
<https://reviews.apache.org/r/58252/#comment244219>
Not yours (it might even be mine), but if we already checked in the previous line `!request.has_subject()`, the only posibility is that it does have a subject and `request.has_subject()` is unnecesary. I would delete it.
- Alexander Rojas
On April 7, 2017, 5:26 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58252/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 5:26 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7014
> https://issues.apache.org/jira/browse/MESOS-7014
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates checks in the local authorizer to allow subjects
> which specify `claims` instead of a `value`.
>
>
> Diffs
> -----
>
> src/authorizer/local/authorizer.cpp e241edf4afa48d35dbbbb94d72e8e8690f5bedfc
>
>
> Diff: https://reviews.apache.org/r/58252/diff/1/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>