You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/29 04:47:37 UTC

[GitHub] [pulsar] coderzc opened a new pull request, #17325: [fix][client-c++] Fix wrong consumers size

coderzc opened a new pull request, #17325:
URL: https://github.com/apache/pulsar/pull/17325

   Fixes #14848
   
   ### Motivation
   
   We should execute `callback` before executing `readerCreatedCallback_`, otherwise, we may get the wrong consumers size. More see:
   https://github.com/apache/pulsar/blob/master/pulsar-client-cpp/lib/ReaderImpl.cc#L84-L92
   
   ### Modifications
   
   execute `callback` before executing `readerCreatedCallback_`
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao commented on pull request #17325: [fix][client-c++] Fix wrong consumers size

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #17325:
URL: https://github.com/apache/pulsar/pull/17325#issuecomment-1244821799

   Hi @coderzc 
   Could you help to cherry-pick this PR to branch-2.9 (To avoid cherry-picking involving bugs)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] coderzc commented on pull request #17325: [fix][client-c++] Fix wrong consumers size

Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #17325:
URL: https://github.com/apache/pulsar/pull/17325#issuecomment-1230173110

   @BewareMyPower PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower merged pull request #17325: [fix][client-c++] Fix wrong consumers size

Posted by GitBox <gi...@apache.org>.
BewareMyPower merged PR #17325:
URL: https://github.com/apache/pulsar/pull/17325


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyepianzhou commented on pull request #17325: [fix][client-c++] Fix wrong consumers size

Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on PR #17325:
URL: https://github.com/apache/pulsar/pull/17325#issuecomment-1346142520

   Hi @coderzc 
   Could you help to cherry-pick this PR to branch-2.10 as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] coderzc commented on pull request #17325: [fix][client-c++] Fix wrong consumers size

Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #17325:
URL: https://github.com/apache/pulsar/pull/17325#issuecomment-1244855368

   > Hi @coderzc Could you help to cherry-pick this PR to branch-2.9 (To avoid cherry-picking involving bugs)
   
   Ok, I will cherry-pick this PR to branch-2.9


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org