You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/11 16:11:11 UTC
[GitHub] [spark] iRakson opened a new pull request #27542: [SPARK-30790]The
dataType of map() should be map
iRakson opened a new pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
`spark.sql("select map()")` returns {}.
After these changes it will return map<null,null>
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
After changes introduced due to #27521, it is important to maintain consistency while using map().
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce any user-facing change?
Yes. Now map() will give map<null,null> instead of {}.
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
### How was this patch tested?
UT added. Migration guide updated as well
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585275881
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584733109
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
iRakson commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r378099765
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -167,9 +175,9 @@ case class CreateMap(children: Seq[Expression]) extends Expression {
override lazy val dataType: MapType = {
MapType(
keyType = TypeCoercion.findCommonTypeDifferentOnlyInNullFlags(keys.map(_.dataType))
- .getOrElse(StringType),
+ .getOrElse(defaultElementType),
Review comment:
In `ArrayBaseMapBuilder`, `Nulltype` is not handled for key. This causes following problem:
```
scala> sql("select map(null,2)")
res1: org.apache.spark.sql.DataFrame = [map(NULL, 2): map<null,int>]
scala> sql("select map(null,2)").collect
scala.MatchError: NullType (of class org.apache.spark.sql.types.NullType$)
at org.apache.spark.sql.catalyst.util.TypeUtils$.getInterpretedOrdering(TypeUtils.scala:67)
at org.apache.spark.sql.catalyst.util.ArrayBasedMapBuilder.keyToIndex$lzycompute(ArrayBasedMapBuilder.scala:37)
```
After removing the assertion we need to handle this.
@cloud-fan [#23124(comment)](https://github.com/apache/spark/pull/23124/commits/9df627465d9f9bcdde129baf1304035f082e5ab6?file-filters%5B%5D=.scala#r235929748)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27542: [SPARK-30790]The dataType
of map() should be map
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584950465
Just to check; we need independent legacy configs for arrays and maps?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585364622
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
iRakson commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r378183603
##########
File path: docs/sql-migration-guide.md
##########
@@ -216,7 +216,9 @@ license: |
- Since Spark 3.0, the `size` function returns `NULL` for the `NULL` input. In Spark version 2.4 and earlier, this function gives `-1` for the same input. To restore the behavior before Spark 3.0, you can set `spark.sql.legacy.sizeOfNull` to `true`.
- - Since Spark 3.0, when the `array` function is called without any parameters, it returns an empty array of `NullType`. In Spark version 2.4 and earlier, it returns an empty array of string type. To restore the behavior before Spark 3.0, you can set `spark.sql.legacy.arrayDefaultToStringType.enabled` to `true`.
+ - Since Spark 3.0, when the `array` function is called without any parameters, it returns an empty array of `NullType`. In Spark version 2.4 and earlier, it returns an empty array of string type. To restore the behavior before Spark 3.0, you can set `spark.sql.legacy.createEmptyCollectionUsingStringType.enabled` to `true`.
+
+ - Since Spark 3.0, when the `map` function is called without any parameters, it returns an empty map with `NullType` as key/value type. In Spark version 2.4 and earlier, it returns an empty map of string type. To restore the behavior before Spark 3.0, you can set `spark.sql.legacy.createEmptyCollectionUsingStringType.enabled` to `true`.
Review comment:
Migration guide is updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585340273
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
iRakson commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r378099765
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -167,9 +175,9 @@ case class CreateMap(children: Seq[Expression]) extends Expression {
override lazy val dataType: MapType = {
MapType(
keyType = TypeCoercion.findCommonTypeDifferentOnlyInNullFlags(keys.map(_.dataType))
- .getOrElse(StringType),
+ .getOrElse(defaultElementType),
Review comment:
After removing the assertion we need to handle this as well [#23124(comment)](https://github.com/apache/spark/pull/23124/commits/9df627465d9f9bcdde129baf1304035f082e5ab6?file-filters%5B%5D=.scala#r235852779) @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r378382513
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2007,12 +2007,13 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
- val LEGACY_ARRAY_DEFAULT_TO_STRING =
- buildConf("spark.sql.legacy.arrayDefaultToStringType.enabled")
+ val LEGACY_CREATE_EMPTY_COLLECTION_USING_STRING_TYPE =
+ buildConf("spark.sql.legacy.createEmptyCollectionUsingStringType.enabled")
.internal()
- .doc("When set to true, it returns an empty array of string type when the `array` " +
- "function is called without any parameters. Otherwise, it returns an empty " +
- "array of `NullType`")
+ .doc("When set to true, it returns an empty array of string type and an empty map with " +
Review comment:
let's match the migration guide:
```
When set to true, Spark returns an empty collection with `StringType` as element type
if the `array`/`map` function is called without any parameters. Otherwise, Spark returns
an empty collection with `NullType` as element type.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r377740365
##########
File path: docs/sql-migration-guide.md
##########
@@ -218,6 +218,8 @@ license: |
- Since Spark 3.0, when the `array` function is called without any parameters, it returns an empty array of `NullType`. In Spark version 2.4 and earlier, it returns an empty array of string type. To restore the behavior before Spark 3.0, you can set `spark.sql.legacy.arrayDefaultToStringType.enabled` to `true`.
+ - Since Spark 3.0, when the `map` function is called without any parameters, it returns an empty map of `NullType`. In Spark version 2.4 and earlier, it returns an empty map of string type. To restore the behavior before Spark 3.0, you can set `spark.sql.legacy.mapDefaultToStringType.enabled` to `true`.
Review comment:
an empty map with `NullType` as key/value type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r378055780
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -167,9 +175,9 @@ case class CreateMap(children: Seq[Expression]) extends Expression {
override lazy val dataType: MapType = {
MapType(
keyType = TypeCoercion.findCommonTypeDifferentOnlyInNullFlags(keys.map(_.dataType))
- .getOrElse(StringType),
+ .getOrElse(defaultElementType),
Review comment:
Can we remove that asserting?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585123688
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23049/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584733115
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118254/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584713709
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585364622
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585364630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118315/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584714406
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r377741289
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala
##########
@@ -3499,11 +3499,17 @@ class DataFrameFunctionsSuite extends QueryTest with SharedSparkSession {
).foreach(assertValuesDoNotChangeAfterCoalesceOrUnion(_))
}
- test("SPARK-21281 use string types by default if map have no argument") {
- val ds = spark.range(1)
- var expectedSchema = new StructType()
- .add("x", MapType(StringType, StringType, valueContainsNull = false), nullable = false)
- assert(ds.select(map().as("x")).schema == expectedSchema)
+ test("SPARK-30790: Empty map of <NullType,NullType> for map function with no arguments") {
Review comment:
can we move it closer to the array test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585437815
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585364630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118315/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585156412
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584718170
**[Test build #118254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118254/testReport)** for PR 27542 at commit [`395eee8`](https://github.com/apache/spark/commit/395eee801dab323b6f32b25b43a4e92d99027551).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585339661
**[Test build #118315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118315/testReport)** for PR 27542 at commit [`e873527`](https://github.com/apache/spark/commit/e873527032ffaed583b211d81f2c9aafebe9fe07).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585232631
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118291/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585123688
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23049/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585521446
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118322/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585232631
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118291/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585339661
**[Test build #118315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118315/testReport)** for PR 27542 at commit [`e873527`](https://github.com/apache/spark/commit/e873527032ffaed583b211d81f2c9aafebe9fe07).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584714393
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584733035
**[Test build #118254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118254/testReport)** for PR 27542 at commit [`395eee8`](https://github.com/apache/spark/commit/395eee801dab323b6f32b25b43a4e92d99027551).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584718780
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
iRakson commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r378051609
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -167,9 +175,9 @@ case class CreateMap(children: Seq[Expression]) extends Expression {
override lazy val dataType: MapType = {
MapType(
keyType = TypeCoercion.findCommonTypeDifferentOnlyInNullFlags(keys.map(_.dataType))
- .getOrElse(StringType),
+ .getOrElse(defaultElementType),
Review comment:
In `ArrayBasedMapBuilder`, we are explicitly asserting that `keyType` can't be `NullType`. So assigning `NullType` here is causing test failures.
@cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585231623
**[Test build #118291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118291/testReport)** for PR 27542 at commit [`3319d3a`](https://github.com/apache/spark/commit/3319d3ab13262e90764c06006b9528844592890b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585275899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118296/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584733115
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118254/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584713709
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585521446
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118322/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson removed a comment on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
iRakson removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585038840
Test cases are failing because key of a map can't be of NullType. @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585340273
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585155781
**[Test build #118296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118296/testReport)** for PR 27542 at commit [`1a066e1`](https://github.com/apache/spark/commit/1a066e1ec71fe7eca329781c76ab75c18de2a0cc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585340286
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23073/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27542: [SPARK-30790]The dataType
of map() should be map
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585436474
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585364486
**[Test build #118315 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118315/testReport)** for PR 27542 at commit [`e873527`](https://github.com/apache/spark/commit/e873527032ffaed583b211d81f2c9aafebe9fe07).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
iRakson commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585026575
> Just to check; we need independent legacy configs for arrays and maps?
That is exactly my doubt as well. As per my opinion we should have a single config for both of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584718780
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
iRakson commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r378141853
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala
##########
@@ -29,12 +29,11 @@ import org.apache.spark.unsafe.array.ByteArrayMethods
*/
class ArrayBasedMapBuilder(keyType: DataType, valueType: DataType) extends Serializable {
assert(!keyType.existsRecursively(_.isInstanceOf[MapType]), "key of map cannot be/contain map")
- assert(keyType != NullType, "map key cannot be null type.")
private lazy val keyToIndex = keyType match {
// Binary type data is `byte[]`, which can't use `==` to check equality.
- case _: AtomicType | _: CalendarIntervalType if !keyType.isInstanceOf[BinaryType] =>
- new java.util.HashMap[Any, Int]()
+ case _: AtomicType | _: CalendarIntervalType | _: NullType
Review comment:
This is done to handle this ->
`scala.MatchError: NullType (of class org.apache.spark.sql.types.NullType$)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r377753061
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala
##########
@@ -3499,11 +3499,17 @@ class DataFrameFunctionsSuite extends QueryTest with SharedSparkSession {
).foreach(assertValuesDoNotChangeAfterCoalesceOrUnion(_))
}
- test("SPARK-21281 use string types by default if map have no argument") {
- val ds = spark.range(1)
- var expectedSchema = new StructType()
- .add("x", MapType(StringType, StringType, valueContainsNull = false), nullable = false)
- assert(ds.select(map().as("x")).schema == expectedSchema)
+ test("SPARK-30790: Empty map of <NullType,NullType> for map function with no arguments") {
+ Seq((true, StringType), (false, NullType)).foreach {
+ case (mapDefaultToString, expectedType) =>
+ withSQLConf(SQLConf.LEGACY_MAP_DEFAULT_TO_STRING.key -> mapDefaultToString.toString) {
+ val schema = spark.range(1).select(map()).schema
+ assert(schema.nonEmpty && schema.head.dataType.isInstanceOf[MapType])
+ val actualKeyType = schema.head.dataType.asInstanceOf[MapType].keyType
+ val actualValueType = schema.head.dataType.asInstanceOf[MapType].valueType
+ assert(actualKeyType === expectedType && actualValueType === expectedType)
Review comment:
nit:
```scala
val schema = spark.range(1).select(map()).schema
val StructType(Array(StructField(_, MapType(keyType, valueType, _), _, _))) = schema
assert(keyType === expectedType)
assert(valueType === expectedType)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
iRakson commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585048687
> how about a single config `spark.sql.legacy.createEmptyCollectionUsingStringType`?
Seems fine to me. I will update code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r377743218
##########
File path: docs/sql-migration-guide.md
##########
@@ -218,6 +218,8 @@ license: |
- Since Spark 3.0, when the `array` function is called without any parameters, it returns an empty array of `NullType`. In Spark version 2.4 and earlier, it returns an empty array of string type. To restore the behavior before Spark 3.0, you can set `spark.sql.legacy.arrayDefaultToStringType.enabled` to `true`.
+ - Since Spark 3.0, when the `map` function is called without any parameters, it returns an empty map of `NullType`. In Spark version 2.4 and earlier, it returns an empty map of string type. To restore the behavior before Spark 3.0, you can set `spark.sql.legacy.mapDefaultToStringType.enabled` to `true`.
Review comment:
Maybe we should say that map's keys and values have either `NullType` or `StringType`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585123050
**[Test build #118291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118291/testReport)** for PR 27542 at commit [`3319d3a`](https://github.com/apache/spark/commit/3319d3ab13262e90764c06006b9528844592890b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27542: [SPARK-30790][SQL] The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27542: [SPARK-30790][SQL] The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585543580
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585437825
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23080/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585156426
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23054/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584733109
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585275881
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585340286
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23073/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585275899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118296/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584718170
**[Test build #118254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118254/testReport)** for PR 27542 at commit [`395eee8`](https://github.com/apache/spark/commit/395eee801dab323b6f32b25b43a4e92d99027551).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585155781
**[Test build #118296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118296/testReport)** for PR 27542 at commit [`1a066e1`](https://github.com/apache/spark/commit/1a066e1ec71fe7eca329781c76ab75c18de2a0cc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585437166
**[Test build #118322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118322/testReport)** for PR 27542 at commit [`e873527`](https://github.com/apache/spark/commit/e873527032ffaed583b211d81f2c9aafebe9fe07).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584718795
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23013/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r378165632
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -167,9 +175,9 @@ case class CreateMap(children: Seq[Expression]) extends Expression {
override lazy val dataType: MapType = {
MapType(
keyType = TypeCoercion.findCommonTypeDifferentOnlyInNullFlags(keys.map(_.dataType))
- .getOrElse(StringType),
+ .getOrElse(defaultElementType),
Review comment:
yea we need to handle it. Let's add `NullType` to `case _: AtomicType | _: CalendarIntervalType if !keyType.isInstanceOf[BinaryType]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r378177054
##########
File path: docs/sql-migration-guide.md
##########
@@ -216,7 +216,9 @@ license: |
- Since Spark 3.0, the `size` function returns `NULL` for the `NULL` input. In Spark version 2.4 and earlier, this function gives `-1` for the same input. To restore the behavior before Spark 3.0, you can set `spark.sql.legacy.sizeOfNull` to `true`.
- - Since Spark 3.0, when the `array` function is called without any parameters, it returns an empty array of `NullType`. In Spark version 2.4 and earlier, it returns an empty array of string type. To restore the behavior before Spark 3.0, you can set `spark.sql.legacy.arrayDefaultToStringType.enabled` to `true`.
+ - Since Spark 3.0, when the `array` function is called without any parameters, it returns an empty array of `NullType`. In Spark version 2.4 and earlier, it returns an empty array of string type. To restore the behavior before Spark 3.0, you can set `spark.sql.legacy.createEmptyCollectionUsingStringType.enabled` to `true`.
+
+ - Since Spark 3.0, when the `map` function is called without any parameters, it returns an empty map with `NullType` as key/value type. In Spark version 2.4 and earlier, it returns an empty map of string type. To restore the behavior before Spark 3.0, you can set `spark.sql.legacy.createEmptyCollectionUsingStringType.enabled` to `true`.
Review comment:
can we combine the 2 items?
```
Since Spark 3.0, when the `array`/`map` function is called without any parameters, it returns an empty collection with `NullType` as element type. ...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585156412
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585437166
**[Test build #118322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118322/testReport)** for PR 27542 at commit [`e873527`](https://github.com/apache/spark/commit/e873527032ffaed583b211d81f2c9aafebe9fe07).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r378381239
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2007,12 +2007,13 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
- val LEGACY_ARRAY_DEFAULT_TO_STRING =
- buildConf("spark.sql.legacy.arrayDefaultToStringType.enabled")
+ val LEGACY_CREATE_EMPTY_COLLECTION_USING_STRING_TYPE =
+ buildConf("spark.sql.legacy.createEmptyCollectionUsingStringType.enabled")
Review comment:
I've sent a config naming proposal to dev list, and `createEmptyCollectionUsingStringType` is a verb so I think we don't need the `.enabled` postfix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r377740536
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2016,6 +2016,15 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val LEGACY_MAP_DEFAULT_TO_STRING =
+ buildConf("spark.sql.legacy.mapDefaultToStringType.enabled")
+ .internal()
+ .doc("When set to true, it returns an empty map of string type when the `map` " +
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584718795
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23013/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585437815
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585521442
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585156426
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23054/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r377741141
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala
##########
@@ -3499,11 +3499,17 @@ class DataFrameFunctionsSuite extends QueryTest with SharedSparkSession {
).foreach(assertValuesDoNotChangeAfterCoalesceOrUnion(_))
}
- test("SPARK-21281 use string types by default if map have no argument") {
- val ds = spark.range(1)
- var expectedSchema = new StructType()
- .add("x", MapType(StringType, StringType, valueContainsNull = false), nullable = false)
- assert(ds.select(map().as("x")).schema == expectedSchema)
+ test("SPARK-30790: Empty map of <NullType,NullType> for map function with no arguments") {
Review comment:
empty map with NullType as key/value type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-584714406
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585047698
how about a single config `spark.sql.legacy.createEmptyCollectionUsingStringType`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585521442
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27542: [SPARK-30790][SQL]
The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27542: [SPARK-30790][SQL] The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
iRakson commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585038840
Test cases are failing because key of a map can't be of NullType. @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585232619
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585274775
**[Test build #118296 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118296/testReport)** for PR 27542 at commit [`1a066e1`](https://github.com/apache/spark/commit/1a066e1ec71fe7eca329781c76ab75c18de2a0cc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585232619
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
iRakson commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r378173118
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -167,9 +175,9 @@ case class CreateMap(children: Seq[Expression]) extends Expression {
override lazy val dataType: MapType = {
MapType(
keyType = TypeCoercion.findCommonTypeDifferentOnlyInNullFlags(keys.map(_.dataType))
- .getOrElse(StringType),
+ .getOrElse(defaultElementType),
Review comment:
Yeah. I updated the PR using that approach only. All the Other review comments are handled as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585123676
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585521083
**[Test build #118322 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118322/testReport)** for PR 27542 at commit [`e873527`](https://github.com/apache/spark/commit/e873527032ffaed583b211d81f2c9aafebe9fe07).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
iRakson commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r378099765
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -167,9 +175,9 @@ case class CreateMap(children: Seq[Expression]) extends Expression {
override lazy val dataType: MapType = {
MapType(
keyType = TypeCoercion.findCommonTypeDifferentOnlyInNullFlags(keys.map(_.dataType))
- .getOrElse(StringType),
+ .getOrElse(defaultElementType),
Review comment:
In `ArrayBaseMapBuilder`, we have handled `Nulltype` for key. This causes following problem:
```
scala> sql("select map(null,2)")
res1: org.apache.spark.sql.DataFrame = [map(NULL, 2): map<null,int>]
scala> sql("select map(null,2)").collect
scala.MatchError: NullType (of class org.apache.spark.sql.types.NullType$)
at org.apache.spark.sql.catalyst.util.TypeUtils$.getInterpretedOrdering(TypeUtils.scala:67)
at org.apache.spark.sql.catalyst.util.ArrayBasedMapBuilder.keyToIndex$lzycompute(ArrayBasedMapBuilder.scala:37)
```
After removing the assertion we need to handle this problem.
@cloud-fan [#23124(comment)](https://github.com/apache/spark/pull/23124/commits/9df627465d9f9bcdde129baf1304035f082e5ab6?file-filters%5B%5D=.scala#r235929748)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
iRakson commented on a change in pull request #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#discussion_r378099765
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -167,9 +175,9 @@ case class CreateMap(children: Seq[Expression]) extends Expression {
override lazy val dataType: MapType = {
MapType(
keyType = TypeCoercion.findCommonTypeDifferentOnlyInNullFlags(keys.map(_.dataType))
- .getOrElse(StringType),
+ .getOrElse(defaultElementType),
Review comment:
After removing the assertion we need to handle this as well #23124(https://github.com/apache/spark/pull/23124/commits/9df627465d9f9bcdde129baf1304035f082e5ab6?file-filters%5B%5D=.scala#r235852779)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27542:
[SPARK-30790]The dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585437825
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23080/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585123676
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27542: [SPARK-30790]The
dataType of map() should be map
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27542: [SPARK-30790]The dataType of map() should be map<null,null>
URL: https://github.com/apache/spark/pull/27542#issuecomment-585123050
**[Test build #118291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118291/testReport)** for PR 27542 at commit [`3319d3a`](https://github.com/apache/spark/commit/3319d3ab13262e90764c06006b9528844592890b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org