You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rob Hartill <ha...@ooo.lanl.gov> on 1995/09/22 18:03:51 UTC

XBITHACK trips people up

At the moment, if you use XBITHACK and try to load an image
which is +x, then XBITHACK jumps in and changes the type to
text/html

This is old news but bad news. XBITHACK should only be activated
on files with a type of text/html.. it doesn't make sense anywhere
else (or does it ?).



Here's a patch which appears to fix the problem. Anyone spot any 
side effects ?


*** mod_include.c.orig  Fri Sep 22 09:50:43 1995
--- mod_include.c       Fri Sep 22 10:02:07 1995
***************
*** 838,843 ****
--- 838,846 ----
                                               &includes_module);
      
      if (*state == xbithack_off) return DECLINED;
+     
+     if (strcmp(r->content_type, "text/html")) return DECLINED;
+     
      return send_parsed_file (r);
  }