You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/27 14:22:35 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6165: arch/arm/Make.defs: unify common source include

xiaoxiang781216 commented on code in PR #6165:
URL: https://github.com/apache/incubator-nuttx/pull/6165#discussion_r859864348


##########
arch/arm/src/Makefile:
##########
@@ -20,6 +20,7 @@
 
 include $(TOPDIR)/Make.defs
 include chip/Make.defs
+include common/Make.defs

Review Comment:
   should we add armvx-y/Make.defs too?
   
   1. armvx-y/Make.defs include common/Make.defs
   2. chip's Make.defs include armvx-y/Make.defs
   
   It's not good to include common/Make.defs here since the chip is hard to replace the unwanted common file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org