Re: [PR] Feature/509 remove osgi defines (celix)

["pnoltes (via GitHub)" <gi...@apache.org>]

pnoltes commented on code in PR #679:
URL: https://github.com/apache/celix/pull/679#discussion_r1383790411


##########
bundles/remote_services/remote_service_admin_shm_v2/rsa_shm/gtest/src/RsaShmIntegrationTestSuite.cc:
##########
@@ -24,8 +24,8 @@ class RsaShmActivatorTestSuite : public ::testing::Test {
 public:
     RsaShmActivatorTestSuite() {
         auto* props = celix_properties_create();
-        celix_properties_set(props, CELIX_FRAMEWORK_FRAMEWORK_STORAGE_CLEAN_NAME, "onFirstInit");
-        celix_properties_set(props, OSGI_FRAMEWORK_FRAMEWORK_STORAGE, ".rsa_shm_cache");
+        celix_properties_set(props, CELIX_FRAMEWORK_CLEAN_CACHE_DIR_ON_CREATE, "onFirstInit");

Review Comment:
   yes, replaced all left over "onFirstInit" with `true`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org