You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "mattisonchao (via GitHub)" <gi...@apache.org> on 2023/01/30 01:52:54 UTC
[GitHub] [pulsar] mattisonchao opened a new pull request, #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
mattisonchao opened a new pull request, #19354:
URL: https://github.com/apache/pulsar/pull/19354
### Motivation
in practice, we should release pooled messages in the reader listener. however, released message will set messageId equals to `null`. and the `acknowledgeCumulativeAsync` method will got this exception.
```java
org.apache.pulsar.client.api.PulsarClientException$InvalidMessageException: Cannot handle message with null messageId
at org.apache.pulsar.client.impl.ConsumerBase.validateMessageId(ConsumerBase.java:392) ~[classes/:?]
at org.apache.pulsar.client.impl.ConsumerBase.acknowledgeCumulativeAsync(ConsumerBase.java:588) ~[classes/:?]
at org.apache.pulsar.client.impl.ReaderImpl$1.received(ReaderImpl.java:105) ~[classes/:?]
at org.apache.pulsar.client.impl.ConsumerBase.callMessageListener(ConsumerBase.java:1124) ~[classes/:?]
at org.apache.pulsar.client.impl.ConsumerBase.lambda$triggerListener$10(ConsumerBase.java:1090) ~[classes/:?]
```
### Modifications
- Create new reference for message id to void pass null argument.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on a diff in pull request #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on code in PR #19354:
URL: https://github.com/apache/pulsar/pull/19354#discussion_r1090146235
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsReaderImpl.java:
##########
@@ -83,8 +83,13 @@ public MultiTopicsReaderImpl(PulsarClientImpl client, ReaderConfigurationData<T>
@Override
public void received(Consumer<T> consumer, Message<T> msg) {
+ final MessageId messageId = msg.getMessageId();
readerListener.received(MultiTopicsReaderImpl.this, msg);
- consumer.acknowledgeCumulativeAsync(msg);
+ consumer.acknowledgeCumulativeAsync(messageId).exceptionally(ex -> {
Review Comment:
Ah, I see, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on code in PR #19354:
URL: https://github.com/apache/pulsar/pull/19354#discussion_r1090138873
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsReaderImpl.java:
##########
@@ -83,8 +83,13 @@ public MultiTopicsReaderImpl(PulsarClientImpl client, ReaderConfigurationData<T>
@Override
public void received(Consumer<T> consumer, Message<T> msg) {
+ final MessageId messageId = msg.getMessageId();
readerListener.received(MultiTopicsReaderImpl.this, msg);
- consumer.acknowledgeCumulativeAsync(msg);
+ consumer.acknowledgeCumulativeAsync(messageId).exceptionally(ex -> {
Review Comment:
Yes, otherwise, the backlog will keep increasing in metrics. Maybe we can consider ack this message in the broker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on a diff in pull request #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on code in PR #19354:
URL: https://github.com/apache/pulsar/pull/19354#discussion_r1090138038
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsReaderImpl.java:
##########
@@ -83,8 +83,13 @@ public MultiTopicsReaderImpl(PulsarClientImpl client, ReaderConfigurationData<T>
@Override
public void received(Consumer<T> consumer, Message<T> msg) {
+ final MessageId messageId = msg.getMessageId();
readerListener.received(MultiTopicsReaderImpl.this, msg);
- consumer.acknowledgeCumulativeAsync(msg);
+ consumer.acknowledgeCumulativeAsync(messageId).exceptionally(ex -> {
Review Comment:
I have another question, do we need acknowledge messages in Reader？ Because the the subscription type is `SubscriptionMode.NonDurable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui commented on code in PR #19354:
URL: https://github.com/apache/pulsar/pull/19354#discussion_r1090119232
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsReaderImpl.java:
##########
@@ -83,8 +83,13 @@ public MultiTopicsReaderImpl(PulsarClientImpl client, ReaderConfigurationData<T>
@Override
public void received(Consumer<T> consumer, Message<T> msg) {
+ final MessageId messageId = msg.getMessageId();
+ consumer.acknowledgeCumulativeAsync(messageId).exceptionally(ex -> {
+ log.error("[{}][{}] auto acknowledge message {} cumulative fail.", getTopic(),
+ getMultiTopicsConsumer().getSubscription(), msg.getMessageId(), ex);
+ return null;
+ });
Review Comment:
Is it better to execute the acknowledgment after triggering the `readerListener`? You already have the message ID, and it is immutable, right? So that we will not change any behavior here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on code in PR #19354:
URL: https://github.com/apache/pulsar/pull/19354#discussion_r1090119600
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsReaderImpl.java:
##########
@@ -83,8 +83,13 @@ public MultiTopicsReaderImpl(PulsarClientImpl client, ReaderConfigurationData<T>
@Override
public void received(Consumer<T> consumer, Message<T> msg) {
+ final MessageId messageId = msg.getMessageId();
+ consumer.acknowledgeCumulativeAsync(messageId).exceptionally(ex -> {
+ log.error("[{}][{}] auto acknowledge message {} cumulative fail.", getTopic(),
+ getMultiTopicsConsumer().getSubscription(), msg.getMessageId(), ex);
+ return null;
+ });
Review Comment:
Ah, a good idea to keep behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao closed pull request #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
URL: https://github.com/apache/pulsar/pull/19354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on a diff in pull request #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on code in PR #19354:
URL: https://github.com/apache/pulsar/pull/19354#discussion_r1090126972
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsReaderImpl.java:
##########
@@ -83,8 +83,13 @@ public MultiTopicsReaderImpl(PulsarClientImpl client, ReaderConfigurationData<T>
@Override
public void received(Consumer<T> consumer, Message<T> msg) {
+ final MessageId messageId = msg.getMessageId();
readerListener.received(MultiTopicsReaderImpl.this, msg);
- consumer.acknowledgeCumulativeAsync(msg);
+ consumer.acknowledgeCumulativeAsync(messageId).exceptionally(ex -> {
+ log.error("[{}][{}] auto acknowledge message {} cumulative fail.", getTopic(),
+ getMultiTopicsConsumer().getSubscription(), msg.getMessageId(), ex);
Review Comment:
Will `msg.getMessageId()` throws NPE here? I think `msg.getMessageId()` should be changed to `messageId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19354:
URL: https://github.com/apache/pulsar/pull/19354#issuecomment-1407953943
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19354](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (719dc16) into [master](https://codecov.io/gh/apache/pulsar/commit/246c2701e5c43e02e9783c82d4d107d06b019951?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (246c270) will **decrease** coverage by `17.26%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19354 +/- ##
=============================================
- Coverage 43.01% 25.75% -17.26%
+ Complexity 10167 6366 -3801
=============================================
Files 747 1643 +896
Lines 72255 125213 +52958
Branches 7786 13646 +5860
=============================================
+ Hits 31080 32248 +1168
- Misses 37577 88319 +50742
- Partials 3598 4646 +1048
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.12% <0.00%> (?)` | |
| unittests | `17.58% <0.00%> (-25.43%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/pulsar/client/impl/MultiTopicsReaderImpl.java](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL011bHRpVG9waWNzUmVhZGVySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/pulsar/client/impl/ReaderImpl.java](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1JlYWRlckltcGwuamF2YQ==) | `56.56% <0.00%> (+17.61%)` | :arrow_up: |
| [...ava/org/apache/pulsar/broker/admin/v1/Brokers.java](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9Ccm9rZXJzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pulsar/broker/admin/v1/Clusters.java](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9DbHVzdGVycy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pulsar/broker/admin/v1/Properties.java](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9Qcm9wZXJ0aWVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pulsar/broker/admin/v2/ResourceGroups.java](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92Mi9SZXNvdXJjZUdyb3Vwcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...pache/pulsar/client/impl/schema/ByteBufSchema.java](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL3NjaGVtYS9CeXRlQnVmU2NoZW1hLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/pulsar/client/impl/TopicConsumerBuilderImpl.java](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1RvcGljQ29uc3VtZXJCdWlsZGVySW1wbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../pulsar/client/impl/MessagePayloadFactoryImpl.java](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL01lc3NhZ2VQYXlsb2FkRmFjdG9yeUltcGwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...lsar/client/impl/schema/writer/ProtobufWriter.java](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL3NjaGVtYS93cml0ZXIvUHJvdG9idWZXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1350 more](https://codecov.io/gh/apache/pulsar/pull/19354?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao merged pull request #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao merged PR #19354:
URL: https://github.com/apache/pulsar/pull/19354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on code in PR #19354:
URL: https://github.com/apache/pulsar/pull/19354#discussion_r1090113747
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsReaderImpl.java:
##########
@@ -83,8 +83,13 @@ public MultiTopicsReaderImpl(PulsarClientImpl client, ReaderConfigurationData<T>
@Override
public void received(Consumer<T> consumer, Message<T> msg) {
+ final MessageId messageId = msg.getMessageId();
Review Comment:
Actually, the `TopicMessageImpl` has its own message id. Therefore, it works well. but I think it's better to keep the same behaviour as `ReaderImpl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on code in PR #19354:
URL: https://github.com/apache/pulsar/pull/19354#discussion_r1090128851
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsReaderImpl.java:
##########
@@ -83,8 +83,13 @@ public MultiTopicsReaderImpl(PulsarClientImpl client, ReaderConfigurationData<T>
@Override
public void received(Consumer<T> consumer, Message<T> msg) {
+ final MessageId messageId = msg.getMessageId();
readerListener.received(MultiTopicsReaderImpl.this, msg);
- consumer.acknowledgeCumulativeAsync(msg);
+ consumer.acknowledgeCumulativeAsync(messageId).exceptionally(ex -> {
+ log.error("[{}][{}] auto acknowledge message {} cumulative fail.", getTopic(),
+ getMultiTopicsConsumer().getSubscription(), msg.getMessageId(), ex);
Review Comment:
Fixed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19354: [fix][client] Fix reader listener can't auto ack with pooled message.
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on code in PR #19354:
URL: https://github.com/apache/pulsar/pull/19354#discussion_r1090120269
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsReaderImpl.java:
##########
@@ -83,8 +83,13 @@ public MultiTopicsReaderImpl(PulsarClientImpl client, ReaderConfigurationData<T>
@Override
public void received(Consumer<T> consumer, Message<T> msg) {
+ final MessageId messageId = msg.getMessageId();
+ consumer.acknowledgeCumulativeAsync(messageId).exceptionally(ex -> {
+ log.error("[{}][{}] auto acknowledge message {} cumulative fail.", getTopic(),
+ getMultiTopicsConsumer().getSubscription(), msg.getMessageId(), ex);
+ return null;
+ });
Review Comment:
Fixed. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org