[jira] [Updated] (HBASE-12272) Generate Thrift code through maven

["Niels Basjes (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niels Basjes updated HBASE-12272:
---------------------------------
    Attachment: HBASE-12272-2014-11-04-v5.patch

Added extra check for ensure the thrift.version is not changed lightly.

So if you now do
{code}
mvn compile -Pcompile-thrift -Dthrift.version=0.9.1
{code}
the build will fail with 
{code}
[FATAL] === HBase Thrift requires the thrift generator version 0.9.0.
[FATAL] === Setting it to something else needs to be reviewed for wire and behavior compatibility.
{code}

> Generate Thrift code through maven
> ----------------------------------
>
>                 Key: HBASE-12272
>                 URL: https://issues.apache.org/jira/browse/HBASE-12272
>             Project: HBase
>          Issue Type: Improvement
>          Components: build, documentation, Thrift
>            Reporter: Niels Basjes
>             Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
>
>         Attachments: HBASE-12272-2014-10-15-v1-PREVIEW.patch, HBASE-12272-2014-10-16-v2.patch, HBASE-12272-2014-10-16-v3.patch, HBASE-12272-2014-10-16-v4.patch, HBASE-12272-2014-11-04-v5.patch
>
>
> The generated thrift code is currently under source control, but the instructions on rebuilding it is buried in package javadocs.
> We should have a simple maven command to rebuild them, similar to what we have for protobufs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)