You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Adrian (JIRA)" <ji...@codehaus.org> on 2006/01/10 11:31:01 UTC

[jira] Commented: (MRELEASE-72) maven-release-plugin doesn't pass username to maven-scm-provider-cvs

    [ http://jira.codehaus.org/browse/MRELEASE-72?page=comments#action_55382 ] 

Adrian commented on MRELEASE-72:
--------------------------------

I imagine this is quite an easy fix, and is important to lots of people using CVS in a commercial environment.

> maven-release-plugin doesn't pass username to maven-scm-provider-cvs
> --------------------------------------------------------------------
>
>          Key: MRELEASE-72
>          URL: http://jira.codehaus.org/browse/MRELEASE-72
>      Project: Maven 2.x Release Plugin
>         Type: Bug

>     Reporter: Jochen Wiedmann
>     Priority: Critical

>
>
> The class CvsScmProvider refuses a CVS url without username. See, for example, line 253ff:
>                 int index = userhost.indexOf( "@" );
>                 if ( index == -1 )
>                 {
>                     result.messages.add( "The userhost part must be on the form: <username>@<hostname>." );
>                     return result;
>                 }
> On the other hand, the maven-release-plugin doesn't pass the full URL to the provider. In AbstractReleaseMojo, an instance of ScmHelper is used, see line 120:
>                repository = getScmManager().makeScmRepository( scmHelper.getUrl() );
> But the ScmHelper's URL is a reformatted URL, with user, password, and so on removed. The effect is that any attempt to run 
>     mvn release:prepare
> with an URL like scm:cvs:pserver:joe@host:/cvs:module is refused with an error message "The scm url is invalid."
> I can't tell which side is wrong and am thus unable to provide a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org