[jira] Commented: (HARMONY-779) [classlib][nio] Refine several methods of o.a.h.nio.internal.DatagramChannelImpl

["Andrew Zhang (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/HARMONY-779?page=comments#action_12419636 ] 

Andrew Zhang commented on HARMONY-779:
--------------------------------------

Hello George,

The fix looks good, thanks!

Best regards,
Andrew

> [classlib][nio] Refine several methods of o.a.h.nio.internal.DatagramChannelImpl
> --------------------------------------------------------------------------------
>
>          Key: HARMONY-779
>          URL: http://issues.apache.org/jira/browse/HARMONY-779
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>  Attachments: nio.diff
>
> Refine several methods of o.a.h.nio.internal.DatagramChannelImpl. The improvements include:
> 1. implConfgiureBlocking method: Remove an unnecessary operation as discussed on mailing-list. [1]
> 2. Change ArrayIndexOutOfBoundsException to IndexOutOfBoundsException in read/write methods as spec specifies and RI also
> throws IndexOutOfBoundsException.
> 3. Delete some unnecessary comment-out codes.
> I'll upload a patch soon.
> Thanks!
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira