svn commit: r1148992 - in /subversion/trunk: notes/knobs subversion/libsvn_subr/dso.c

[ar...@apache.org]

Author: arfrever
Date: Thu Jul 21 00:47:58 2011
New Revision: 1148992

URL: http://svn.apache.org/viewvc?rev=1148992&view=rev
Log:
Follow-up to r1148374:

* subversion/libsvn_subr/dso.c
  (svn_dso_load): Print error message when SVN_DEBUG_DSO is defined. Also
   improve error message.

* notes/knobs: Document SVN_DEBUG_DSO.

Modified:
    subversion/trunk/notes/knobs
    subversion/trunk/subversion/libsvn_subr/dso.c

Modified: subversion/trunk/notes/knobs
URL: http://svn.apache.org/viewvc/subversion/trunk/notes/knobs?rev=1148992&r1=1148991&r2=1148992&view=diff
==============================================================================
--- subversion/trunk/notes/knobs (original)
+++ subversion/trunk/notes/knobs Thu Jul 21 00:47:58 2011
@@ -52,6 +52,7 @@ SVN_DEBUG
 SVN_CLIENT_COMMIT_DEBUG
 SVN_DEBUG_CACHE_DUMP_STATS
 SVN_DEBUG_CACHE_MEMBUFFER
+SVN_DEBUG_DSO
 SVN_DEBUG_WORK_QUEUE
 PACK_AFTER_EVERY_COMMIT
 DEBUG_DOUBLE_FREE
@@ -262,6 +263,14 @@ SVN_I_LIKE_LATENCY_SO_IGNORE_HTTPV2
   Default:   not defined
   Suggested: defined, not defined
 
+5.6 SVN_DEBUG_DSO
+
+  Scope:     libsvn_subr (dso)
+  Purpose:   detection of failures of dynamic loading of libraries
+  Range:     definedness
+  Default:   not defined
+  Suggested: defined, not defined
+
 5.7 SVN_DEBUG_WORK_QUEUE
 
   Scope:     libsvn_wc (workqueue)
@@ -278,7 +287,7 @@ SVN_I_LIKE_LATENCY_SO_IGNORE_HTTPV2
   Default:   not defined
   Suggested: defined, not defined
 
-5.6 DEBUG_DOUBLE_FREE
+5.9 DEBUG_DOUBLE_FREE
 
   Scope:     serf
   Purpose:   detect double-free calls to serf_bucket_mem_free()
@@ -286,7 +295,7 @@ SVN_I_LIKE_LATENCY_SO_IGNORE_HTTPV2
   Default:   defined
   Suggested: defined, not defined
 
-5.9 SERF_VERBOSE
+5.10 SERF_VERBOSE
 
   Scope:     serf
   Purpose:   write protocol handling debug information to stdout
@@ -294,7 +303,7 @@ SVN_I_LIKE_LATENCY_SO_IGNORE_HTTPV2
   Default:   not defined
   Suggested: defined, not defined
 
-5.10 SSL_VERBOSE
+5.11 SSL_VERBOSE
 
   Scope:     serf
   Purpose:   write SSL bucket handling debug information to stdout
@@ -302,7 +311,7 @@ SVN_I_LIKE_LATENCY_SO_IGNORE_HTTPV2
   Default:   not defined
   Suggested: defined, not defined
 
-5.11 SVN_DEPRECATED
+5.12 SVN_DEPRECATED
 
   Scope:     (everywhere)
   Purpose:   disable "deprecated function calls" warnings
@@ -310,7 +319,7 @@ SVN_I_LIKE_LATENCY_SO_IGNORE_HTTPV2
   Default:   (compiler dependant)
   Suggested: "" (disable deprecation warnings), or compiler-specific decorators
 
-5.12 SVN_FS__TRAIL_DEBUG
+5.13 SVN_FS__TRAIL_DEBUG
 
   Scope:     libsvn_fs_base
   Purpose:   

Modified: subversion/trunk/subversion/libsvn_subr/dso.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/dso.c?rev=1148992&r1=1148991&r2=1148992&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/dso.c (original)
+++ subversion/trunk/subversion/libsvn_subr/dso.c Thu Jul 21 00:47:58 2011
@@ -105,9 +105,12 @@ svn_dso_load(apr_dso_handle_t **dso, con
       status = apr_dso_load(dso, fname, dso_pool);
       if (status)
         {
-#if 0
+#ifdef SVN_DEBUG_DSO
           char buf[1024];
-          fprintf(stderr, "%s\n", apr_dso_error(*dso, buf, 1024));
+          fprintf(stderr,
+                  "Dynamic loading of '%s' failed with the following error:\n%s\n",
+                  fname,
+                  apr_dso_error(*dso, buf, 1024));
 #endif
           *dso = NULL;