[jira] [Commented] (PDFBOX-4544) COSWriter.doWriteHeader(COSDocument) should use the document specified as parameter

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838698#comment-16838698 ] 

ASF subversion and git services commented on PDFBOX-4544:
---------------------------------------------------------

Commit 1859192 from Tilman Hausherr in branch 'pdfbox/branches/issue45'
[ https://svn.apache.org/r1859192 ]

PDFBOX-4544: use the document specified as parameter, as suggested by Jonathan

> COSWriter.doWriteHeader(COSDocument) should use the document specified as parameter
> -----------------------------------------------------------------------------------
>
>                 Key: PDFBOX-4544
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4544
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Writing
>    Affects Versions: 2.0.14
>            Reporter: Jonathan
>            Priority: Trivial
>
> {{COSWriter.doWriteHeader(COSDocument)}} currently takes a COSDocument as a parameter and its javadoc specifies that this document is used to retrieve the header data from. Still, the implementation actually uses the property {{fdDocument}} or {{pdDocument}} to get the pdf version number. This is usually equivalent to using the passed document, but there may be cases where this violates the contract specified in the javadoc. Besides, using the passed doc results in slightly less verbose code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org