You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/16 02:56:44 UTC

[GitHub] [iotdb] jixuan1989 commented on pull request #2684: [IOTDB-1156] Improve the quality and efficiency of code formatting

jixuan1989 commented on pull request #2684:
URL: https://github.com/apache/iotdb/pull/2684#issuecomment-779548450


   > https://issues.apache.org/jira/browse/IOTDB-1157
   
   It is not caused by sonar version.
   
   If you want to avoid warnings, see [1] , by using 
   ```
   - uses: actions/checkout@v2
     with:
       fetch-depth: 0
   ```
   
   If you want to solve NullPointer issues, I have no idea. If you check the sonar command, you will find the problem is `sonar.login` is null, 
   ![image](https://user-images.githubusercontent.com/1021782/108012809-4b1a4800-7045-11eb-860b-adbec0ab4aec.png)
   
   see [2] and [3] for why. and that is why I open PR #2681 
   
   [1] https://community.sonarsource.com/t/sonarcloud-with-github-actions/22713
   [2] https://www.google.com/url?q=https://help.github.com/en/articles/events-that-trigger-workflows%23pull-request-events-for-forked-repositories&source=gmail&ust=1613530497486000&usg=AFQjCNEfebNVY_hNI4Gtz41Cba39YTgLhw
   [3] https://lists.apache.org/thread.html/rffca7a170b1e982c050279bf80802660b2c18131963b34c22122fb95%40%3Cbuilds.apache.org%3E


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org