You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "robertwb (via GitHub)" <gi...@apache.org> on 2023/04/27 23:59:48 UTC
[GitHub] [beam] robertwb opened a new pull request, #26462: Add warning and extra flag about disabling Dataflow Runner v2 for Python.
robertwb opened a new pull request, #26462:
URL: https://github.com/apache/beam/pull/26462
The vast majority of pipelines are already running on Runner v2 (possibly opted in by the service) and the majority of those that are not are on old SDKs.
This paves the way for removing obsolete Runner v1 support from newer SDKs, starting with Beam 2.50.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb merged pull request #26462: Add warning and extra flag about disabling Dataflow Runner v2 for Python.
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb merged PR #26462:
URL: https://github.com/apache/beam/pull/26462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a diff in pull request #26462: Add warning and extra flag about disabling Dataflow Runner v2 for Python.
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #26462:
URL: https://github.com/apache/beam/pull/26462#discussion_r1180258933
##########
sdks/python/apache_beam/runners/dataflow/dataflow_runner.py:
##########
@@ -368,6 +368,14 @@ def _check_for_unsupported_features_on_non_portable_worker(self, pipeline):
def run_pipeline(self, pipeline, options, pipeline_proto=None):
"""Remotely executes entire pipeline or parts reachable from node."""
+ if _is_runner_v2_disabled(options):
+ debug_options = options.view_as(DebugOptions)
+ if not debug_options.lookup_experiment('disable_runner_v2_until_v2.50'):
+ raise ValueError(
+ 'disable_runner_v2 is deprecated in Beam Python ' +
+ beam.version.__version__ + '. ' +
+ 'If needed, please use disable_runner_v2_until_v2.50.')
Review Comment:
disable_runner_v2_until_2023
```suggestion
raise ValueError(
'disable_runner_v2 is deprecated in Beam Python ' +
beam.version.__version__ +
' and this execution mode will be removed in a future Beam SDK. '
'If needed, please use: '
'"--experiments=disable_runner_v2_until_v2.50".')
```
##########
sdks/python/apache_beam/runners/dataflow/dataflow_runner.py:
##########
@@ -368,6 +368,14 @@ def _check_for_unsupported_features_on_non_portable_worker(self, pipeline):
def run_pipeline(self, pipeline, options, pipeline_proto=None):
"""Remotely executes entire pipeline or parts reachable from node."""
+ if _is_runner_v2_disabled(options):
+ debug_options = options.view_as(DebugOptions)
+ if not debug_options.lookup_experiment('disable_runner_v2_until_v2.50'):
+ raise ValueError(
+ 'disable_runner_v2 is deprecated in Beam Python ' +
+ beam.version.__version__ + '. ' +
+ 'If needed, please use disable_runner_v2_until_v2.50.')
Review Comment:
```suggestion
raise ValueError(
'disable_runner_v2 is deprecated in Beam Python ' +
beam.version.__version__ +
' and this execution mode will be removed in a future Beam SDK. '
'If needed, please use: '
'"--experiments=disable_runner_v2_until_v2.50".')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26462: Add warning and extra flag about disabling Dataflow Runner v2 for Python.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26462:
URL: https://github.com/apache/beam/pull/26462#issuecomment-1526880505
## [Codecov](https://codecov.io/gh/apache/beam/pull/26462?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#26462](https://codecov.io/gh/apache/beam/pull/26462?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83aa2b6) into [master](https://codecov.io/gh/apache/beam/commit/3440ae59a815e2ee90528b503d116a21ac5b1672?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3440ae5) will **decrease** coverage by `0.01%`.
> The diff coverage is `25.00%`.
```diff
@@ Coverage Diff @@
## master #26462 +/- ##
==========================================
- Coverage 81.11% 81.10% -0.01%
==========================================
Files 469 469
Lines 67294 67304 +10
==========================================
+ Hits 54583 54587 +4
- Misses 12711 12717 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `81.10% <25.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/26462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/26462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXIucHk=) | `81.56% <25.00%> (-0.19%)` | :arrow_down: |
... and [7 files with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/26462/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26462: Add warning and extra flag about disabling Dataflow Runner v2 for Python.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26462:
URL: https://github.com/apache/beam/pull/26462#issuecomment-1526855818
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @AnandInguva for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #26462: Add warning and extra flag about disabling Dataflow Runner v2 for Python.
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #26462:
URL: https://github.com/apache/beam/pull/26462#issuecomment-1530010431
Run Python_Integration PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org