You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/14 05:44:21 UTC
[GitHub] [netbeans] jlahoda opened a new pull request, #4788: [NETBEANS-4763] Handling switch expressions, case rules and exhaustive switches more correctly.
jlahoda opened a new pull request, #4788:
URL: https://github.com/apache/netbeans/pull/4788
---
**^Add meaningful description above**
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4788: [NETBEANS-4763] Handling switch expressions, case rules and exhaustive switches more correctly.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4788:
URL: https://github.com/apache/netbeans/pull/4788#issuecomment-1368277490
> Thanks for merging - I don't see a reason why not!
We are always a bit careful with reviewed PRs which didn't have their tests run for a long time. It happened before that it broke master which isn't a huge problem since it can be fixed again but it still is annoying so we try to avoid it if possible.
The problem here is that travis is now gone but was still there when this PR ran, so to run the tests again someone would have to push into this PR and rebase. Since this is a small PR and is easy to check I think its fine to simply merge it without the extra steps (master is green so everything is looking good so far :)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #4788: [NETBEANS-4763] Handling switch expressions, case rules and exhaustive switches more correctly.
Posted by GitBox <gi...@apache.org>.
mbien merged PR #4788:
URL: https://github.com/apache/netbeans/pull/4788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4788: [NETBEANS-4763] Handling switch expressions, case rules and exhaustive switches more correctly.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4788:
URL: https://github.com/apache/netbeans/pull/4788#issuecomment-1368113746
this looks ready to merge to me, tests are green too. @jlahoda @matthiasblaesing should we get this in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4788: [NETBEANS-4763] Handling switch expressions, case rules and exhaustive switches more correctly.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4788:
URL: https://github.com/apache/netbeans/pull/4788#issuecomment-1282324872
@sdedic @jtulach would be good if either/both of you could take a look, confirm the fix and merge before freeze.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4788: [NETBEANS-4763] Handling switch expressions, case rules and exhaustive switches more correctly.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4788:
URL: https://github.com/apache/netbeans/pull/4788#issuecomment-1368273232
going to risk it and merge. `java.hints` batch1 and batch2 ran on CI and this particular test does also run locally for me (started with IDE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #4788: [NETBEANS-4763] Handling switch expressions, case rules and exhaustive switches more correctly.
Posted by GitBox <gi...@apache.org>.
jlahoda commented on PR #4788:
URL: https://github.com/apache/netbeans/pull/4788#issuecomment-1368274545
Thanks for merging - I don't see a reason why not!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4788: [NETBEANS-4763] Handling switch expressions, case rules and exhaustive switches more correctly.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4788:
URL: https://github.com/apache/netbeans/pull/4788#issuecomment-1368183487
@mbien I saw this yesterday and I agree. I ran test tonight and locally I saw failures, but these were timeouts and language depedneded problems. The corresponding tests were ran on the github actions infrastructure and there they worked. So yes this should go in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists