You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/08/05 16:40:09 UTC

[GitHub] [incubator-shenyu] strawberry-crisis opened a new pull request #1884: [ISSUE #1866] Remove lombok dependency from

strawberry-crisis opened a new pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884


   // Describe your PR here; eg. Fixes #issueNo
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor/).
   - [x] You submit test cases (unit or integration tests) that back your changes.
   - [x] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884#issuecomment-893987772


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1884](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (290bbd8) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fced0b9fa5f8970dd5f9b539638f47a536c050d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fced0b9) will **decrease** coverage by `1.17%`.
   > The diff coverage is `45.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1884      +/-   ##
   ============================================
   - Coverage     68.33%   67.15%   -1.18%     
   - Complexity     2710     2735      +25     
   ============================================
     Files           492      496       +4     
     Lines         11163    11434     +271     
     Branches       1091     1098       +7     
   ============================================
   + Hits           7628     7679      +51     
   - Misses         2959     3170     +211     
   - Partials        576      585       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/apache/dubbo/proxy/ApacheDubboProxyService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vcHJveHkvQXBhY2hlRHViYm9Qcm94eVNlcnZpY2UuamF2YQ==) | `57.69% <ø> (-1.57%)` | :arrow_down: |
   | [...enyu/plugin/grpc/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9BcHBsaWNhdGlvbkNvbmZpZ0NhY2hlLmphdmE=) | `77.50% <ø> (-0.55%)` | :arrow_down: |
   | [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `64.70% <ø> (-29.74%)` | :arrow_down: |
   | [...he/shenyu/plugin/grpc/loadbalance/SubChannels.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9TdWJDaGFubmVscy5qYXZh) | `82.50% <0.00%> (-6.69%)` | :arrow_down: |
   | [...n/grpc/loadbalance/picker/AbstractReadyPicker.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9waWNrZXIvQWJzdHJhY3RSZWFkeVBpY2tlci5qYXZh) | `64.51% <ø> (-1.11%)` | :arrow_down: |
   | [...henyu/plugin/grpc/proto/ShenyuGrpcCallRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9wcm90by9TaGVueXVHcnBjQ2FsbFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...plugin/httpclient/config/HttpClientProperties.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9jb25maWcvSHR0cENsaWVudFByb3BlcnRpZXMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../shenyu/plugin/hystrix/builder/HystrixBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9idWlsZGVyL0h5c3RyaXhCdWlsZGVyLmphdmE=) | `98.18% <ø> (-0.04%)` | :arrow_down: |
   | [...u/plugin/modify/response/ModifyResponsePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvTW9kaWZ5UmVzcG9uc2VQbHVnaW4uamF2YQ==) | `18.30% <ø> (ø)` | |
   | [.../response/cache/ModifyResponseRuleHandleCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvY2FjaGUvTW9kaWZ5UmVzcG9uc2VSdWxlSGFuZGxlQ2FjaGUuamF2YQ==) | `66.66% <ø> (-8.34%)` | :arrow_down: |
   | ... and [68 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fced0b9...290bbd8](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] strawberry-crisis commented on a change in pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
strawberry-crisis commented on a change in pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884#discussion_r683928944



##########
File path: shenyu-plugin/shenyu-plugin-grpc/src/test/java/org/apache/shenyu/plugin/grpc/proto/MyStreamObserver.java
##########
@@ -28,26 +27,23 @@ public MyStreamObserver(final Boolean state) {
         this.state = state;
     }
 
-    @SneakyThrows
     @Override
     public void onNext(final Boolean value) {
         if (!value) {
-            throw new Exception("exception");
+            throw new RuntimeException("exception");

Review comment:
       OK




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] strawberry-crisis commented on pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
strawberry-crisis commented on pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884#issuecomment-894170105


   > Hi, sorry , can you fix this Conflicting files
   
   No problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884#issuecomment-893987772


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1884](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (290bbd8) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fced0b9fa5f8970dd5f9b539638f47a536c050d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fced0b9) will **decrease** coverage by `0.87%`.
   > The diff coverage is `45.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1884      +/-   ##
   ============================================
   - Coverage     68.33%   67.45%   -0.88%     
   - Complexity     2710     2744      +34     
   ============================================
     Files           492      496       +4     
     Lines         11163    11437     +274     
     Branches       1091     1100       +9     
   ============================================
   + Hits           7628     7715      +87     
   - Misses         2959     3140     +181     
   - Partials        576      582       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/apache/dubbo/proxy/ApacheDubboProxyService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vcHJveHkvQXBhY2hlRHViYm9Qcm94eVNlcnZpY2UuamF2YQ==) | `57.69% <ø> (-1.57%)` | :arrow_down: |
   | [...enyu/plugin/grpc/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9BcHBsaWNhdGlvbkNvbmZpZ0NhY2hlLmphdmE=) | `77.50% <ø> (-0.55%)` | :arrow_down: |
   | [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `94.11% <ø> (-0.33%)` | :arrow_down: |
   | [...he/shenyu/plugin/grpc/loadbalance/SubChannels.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9TdWJDaGFubmVscy5qYXZh) | `82.50% <0.00%> (-6.69%)` | :arrow_down: |
   | [...n/grpc/loadbalance/picker/AbstractReadyPicker.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9waWNrZXIvQWJzdHJhY3RSZWFkeVBpY2tlci5qYXZh) | `64.51% <ø> (-1.11%)` | :arrow_down: |
   | [...henyu/plugin/grpc/proto/ShenyuGrpcCallRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9wcm90by9TaGVueXVHcnBjQ2FsbFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...plugin/httpclient/config/HttpClientProperties.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9jb25maWcvSHR0cENsaWVudFByb3BlcnRpZXMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../shenyu/plugin/hystrix/builder/HystrixBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9idWlsZGVyL0h5c3RyaXhCdWlsZGVyLmphdmE=) | `98.18% <ø> (-0.04%)` | :arrow_down: |
   | [...u/plugin/modify/response/ModifyResponsePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvTW9kaWZ5UmVzcG9uc2VQbHVnaW4uamF2YQ==) | `18.30% <ø> (ø)` | |
   | [.../response/cache/ModifyResponseRuleHandleCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvY2FjaGUvTW9kaWZ5UmVzcG9uc2VSdWxlSGFuZGxlQ2FjaGUuamF2YQ==) | `66.66% <ø> (-8.34%)` | :arrow_down: |
   | ... and [62 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fced0b9...290bbd8](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884#issuecomment-893987772


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1884](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (290bbd8) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fced0b9fa5f8970dd5f9b539638f47a536c050d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fced0b9) will **decrease** coverage by `0.67%`.
   > The diff coverage is `46.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1884      +/-   ##
   ============================================
   - Coverage     68.33%   67.65%   -0.68%     
   - Complexity     2710     2745      +35     
   ============================================
     Files           492      496       +4     
     Lines         11163    11437     +274     
     Branches       1091     1100       +9     
   ============================================
   + Hits           7628     7738     +110     
   - Misses         2959     3119     +160     
   - Partials        576      580       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/apache/dubbo/proxy/ApacheDubboProxyService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vcHJveHkvQXBhY2hlRHViYm9Qcm94eVNlcnZpY2UuamF2YQ==) | `57.69% <ø> (-1.57%)` | :arrow_down: |
   | [...enyu/plugin/grpc/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9BcHBsaWNhdGlvbkNvbmZpZ0NhY2hlLmphdmE=) | `77.50% <ø> (-0.55%)` | :arrow_down: |
   | [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `94.11% <ø> (-0.33%)` | :arrow_down: |
   | [...he/shenyu/plugin/grpc/loadbalance/SubChannels.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9TdWJDaGFubmVscy5qYXZh) | `82.50% <0.00%> (-6.69%)` | :arrow_down: |
   | [...n/grpc/loadbalance/picker/AbstractReadyPicker.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9waWNrZXIvQWJzdHJhY3RSZWFkeVBpY2tlci5qYXZh) | `64.51% <ø> (-1.11%)` | :arrow_down: |
   | [...henyu/plugin/grpc/proto/ShenyuGrpcCallRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9wcm90by9TaGVueXVHcnBjQ2FsbFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...plugin/httpclient/config/HttpClientProperties.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9jb25maWcvSHR0cENsaWVudFByb3BlcnRpZXMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../shenyu/plugin/hystrix/builder/HystrixBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9idWlsZGVyL0h5c3RyaXhCdWlsZGVyLmphdmE=) | `98.18% <ø> (-0.04%)` | :arrow_down: |
   | [...u/plugin/modify/response/ModifyResponsePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvTW9kaWZ5UmVzcG9uc2VQbHVnaW4uamF2YQ==) | `18.30% <ø> (ø)` | |
   | [.../response/cache/ModifyResponseRuleHandleCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvY2FjaGUvTW9kaWZ5UmVzcG9uc2VSdWxlSGFuZGxlQ2FjaGUuamF2YQ==) | `66.66% <ø> (-8.34%)` | :arrow_down: |
   | ... and [60 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fced0b9...290bbd8](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] yu199195 commented on pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
yu199195 commented on pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884#issuecomment-894141794


   Hi, sorry , can you fix this Conflicting files 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] KevinClair commented on a change in pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
KevinClair commented on a change in pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884#discussion_r683911359



##########
File path: shenyu-plugin/shenyu-plugin-grpc/src/test/java/org/apache/shenyu/plugin/grpc/proto/MyStreamObserver.java
##########
@@ -28,26 +27,23 @@ public MyStreamObserver(final Boolean state) {
         this.state = state;
     }
 
-    @SneakyThrows
     @Override
     public void onNext(final Boolean value) {
         if (!value) {
-            throw new Exception("exception");
+            throw new RuntimeException("exception");

Review comment:
        Replace with `ShenyuException`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] HessTina-YuI merged pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
HessTina-YuI merged pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884#issuecomment-893987772


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1884](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b625df1) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/07e085c40e847a921f3c94c70676aa3dd266446b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (07e085c) will **decrease** coverage by `0.35%`.
   > The diff coverage is `61.49%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1884      +/-   ##
   ============================================
   - Coverage     68.20%   67.85%   -0.36%     
   - Complexity     2758     2797      +39     
   ============================================
     Files           497      500       +3     
     Lines         11328    11556     +228     
     Branches       1114     1118       +4     
   ============================================
   + Hits           7726     7841     +115     
   - Misses         3022     3149     +127     
   + Partials        580      566      -14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/apache/dubbo/proxy/ApacheDubboProxyService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vcHJveHkvQXBhY2hlRHViYm9Qcm94eVNlcnZpY2UuamF2YQ==) | `57.69% <ø> (-1.57%)` | :arrow_down: |
   | [...enyu/plugin/grpc/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9BcHBsaWNhdGlvbkNvbmZpZ0NhY2hlLmphdmE=) | `77.50% <ø> (-0.55%)` | :arrow_down: |
   | [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `94.11% <ø> (-0.33%)` | :arrow_down: |
   | [...he/shenyu/plugin/grpc/loadbalance/SubChannels.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9TdWJDaGFubmVscy5qYXZh) | `82.50% <0.00%> (-6.69%)` | :arrow_down: |
   | [...n/grpc/loadbalance/picker/AbstractReadyPicker.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9waWNrZXIvQWJzdHJhY3RSZWFkeVBpY2tlci5qYXZh) | `64.51% <ø> (-1.11%)` | :arrow_down: |
   | [...henyu/plugin/grpc/proto/ShenyuGrpcCallRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9wcm90by9TaGVueXVHcnBjQ2FsbFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...plugin/httpclient/config/HttpClientProperties.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9jb25maWcvSHR0cENsaWVudFByb3BlcnRpZXMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../shenyu/plugin/hystrix/builder/HystrixBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9idWlsZGVyL0h5c3RyaXhCdWlsZGVyLmphdmE=) | `98.18% <ø> (-0.04%)` | :arrow_down: |
   | [...u/plugin/modify/response/ModifyResponsePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvTW9kaWZ5UmVzcG9uc2VQbHVnaW4uamF2YQ==) | `18.30% <ø> (ø)` | |
   | [.../response/cache/ModifyResponseRuleHandleCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvY2FjaGUvTW9kaWZ5UmVzcG9uc2VSdWxlSGFuZGxlQ2FjaGUuamF2YQ==) | `66.66% <ø> (-8.34%)` | :arrow_down: |
   | ... and [65 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [52b059b...b625df1](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884#issuecomment-893987772


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1884](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b625df1) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/07e085c40e847a921f3c94c70676aa3dd266446b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (07e085c) will **decrease** coverage by `0.69%`.
   > The diff coverage is `61.30%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1884      +/-   ##
   ============================================
   - Coverage     68.20%   67.50%   -0.70%     
   - Complexity     2758     2789      +31     
   ============================================
     Files           497      500       +3     
     Lines         11328    11556     +228     
     Branches       1114     1118       +4     
   ============================================
   + Hits           7726     7801      +75     
   - Misses         3022     3188     +166     
   + Partials        580      567      -13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/apache/dubbo/proxy/ApacheDubboProxyService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vcHJveHkvQXBhY2hlRHViYm9Qcm94eVNlcnZpY2UuamF2YQ==) | `57.69% <ø> (-1.57%)` | :arrow_down: |
   | [...enyu/plugin/grpc/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9BcHBsaWNhdGlvbkNvbmZpZ0NhY2hlLmphdmE=) | `77.50% <ø> (-0.55%)` | :arrow_down: |
   | [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `64.70% <ø> (-29.74%)` | :arrow_down: |
   | [...he/shenyu/plugin/grpc/loadbalance/SubChannels.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9TdWJDaGFubmVscy5qYXZh) | `82.50% <0.00%> (-6.69%)` | :arrow_down: |
   | [...n/grpc/loadbalance/picker/AbstractReadyPicker.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9waWNrZXIvQWJzdHJhY3RSZWFkeVBpY2tlci5qYXZh) | `64.51% <ø> (-1.11%)` | :arrow_down: |
   | [...henyu/plugin/grpc/proto/ShenyuGrpcCallRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9wcm90by9TaGVueXVHcnBjQ2FsbFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...plugin/httpclient/config/HttpClientProperties.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9jb25maWcvSHR0cENsaWVudFByb3BlcnRpZXMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../shenyu/plugin/hystrix/builder/HystrixBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9idWlsZGVyL0h5c3RyaXhCdWlsZGVyLmphdmE=) | `98.18% <ø> (-0.04%)` | :arrow_down: |
   | [...u/plugin/modify/response/ModifyResponsePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvTW9kaWZ5UmVzcG9uc2VQbHVnaW4uamF2YQ==) | `18.30% <ø> (ø)` | |
   | [.../response/cache/ModifyResponseRuleHandleCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvY2FjaGUvTW9kaWZ5UmVzcG9uc2VSdWxlSGFuZGxlQ2FjaGUuamF2YQ==) | `66.66% <ø> (-8.34%)` | :arrow_down: |
   | ... and [69 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [52b059b...b625df1](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884#issuecomment-893987772


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1884](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b625df1) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/07e085c40e847a921f3c94c70676aa3dd266446b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (07e085c) will **decrease** coverage by `0.73%`.
   > The diff coverage is `61.30%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1884      +/-   ##
   ============================================
   - Coverage     68.20%   67.47%   -0.74%     
   - Complexity     2758     2789      +31     
   ============================================
     Files           497      500       +3     
     Lines         11328    11553     +225     
     Branches       1114     1116       +2     
   ============================================
   + Hits           7726     7795      +69     
   - Misses         3022     3189     +167     
   + Partials        580      569      -11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/apache/dubbo/proxy/ApacheDubboProxyService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vcHJveHkvQXBhY2hlRHViYm9Qcm94eVNlcnZpY2UuamF2YQ==) | `57.69% <ø> (-1.57%)` | :arrow_down: |
   | [...enyu/plugin/grpc/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9BcHBsaWNhdGlvbkNvbmZpZ0NhY2hlLmphdmE=) | `77.50% <ø> (-0.55%)` | :arrow_down: |
   | [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `64.70% <ø> (-29.74%)` | :arrow_down: |
   | [...he/shenyu/plugin/grpc/loadbalance/SubChannels.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9TdWJDaGFubmVscy5qYXZh) | `82.50% <0.00%> (-6.69%)` | :arrow_down: |
   | [...n/grpc/loadbalance/picker/AbstractReadyPicker.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9waWNrZXIvQWJzdHJhY3RSZWFkeVBpY2tlci5qYXZh) | `64.51% <ø> (-1.11%)` | :arrow_down: |
   | [...henyu/plugin/grpc/proto/ShenyuGrpcCallRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9wcm90by9TaGVueXVHcnBjQ2FsbFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...plugin/httpclient/config/HttpClientProperties.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9jb25maWcvSHR0cENsaWVudFByb3BlcnRpZXMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../shenyu/plugin/hystrix/builder/HystrixBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9idWlsZGVyL0h5c3RyaXhCdWlsZGVyLmphdmE=) | `98.18% <ø> (-0.04%)` | :arrow_down: |
   | [...u/plugin/modify/response/ModifyResponsePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvTW9kaWZ5UmVzcG9uc2VQbHVnaW4uamF2YQ==) | `18.30% <ø> (ø)` | |
   | [.../response/cache/ModifyResponseRuleHandleCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvY2FjaGUvTW9kaWZ5UmVzcG9uc2VSdWxlSGFuZGxlQ2FjaGUuamF2YQ==) | `66.66% <ø> (-8.34%)` | :arrow_down: |
   | ... and [73 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [52b059b...b625df1](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884#issuecomment-893987772


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1884](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b625df1) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/07e085c40e847a921f3c94c70676aa3dd266446b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (07e085c) will **decrease** coverage by `0.48%`.
   > The diff coverage is `61.30%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1884      +/-   ##
   ============================================
   - Coverage     68.20%   67.72%   -0.49%     
   - Complexity     2758     2797      +39     
   ============================================
     Files           497      500       +3     
     Lines         11328    11556     +228     
     Branches       1114     1118       +4     
   ============================================
   + Hits           7726     7826     +100     
   - Misses         3022     3165     +143     
   + Partials        580      565      -15     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/apache/dubbo/proxy/ApacheDubboProxyService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vcHJveHkvQXBhY2hlRHViYm9Qcm94eVNlcnZpY2UuamF2YQ==) | `57.69% <ø> (-1.57%)` | :arrow_down: |
   | [...enyu/plugin/grpc/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9BcHBsaWNhdGlvbkNvbmZpZ0NhY2hlLmphdmE=) | `77.50% <ø> (-0.55%)` | :arrow_down: |
   | [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `94.11% <ø> (-0.33%)` | :arrow_down: |
   | [...he/shenyu/plugin/grpc/loadbalance/SubChannels.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9TdWJDaGFubmVscy5qYXZh) | `82.50% <0.00%> (-6.69%)` | :arrow_down: |
   | [...n/grpc/loadbalance/picker/AbstractReadyPicker.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9waWNrZXIvQWJzdHJhY3RSZWFkeVBpY2tlci5qYXZh) | `64.51% <ø> (-1.11%)` | :arrow_down: |
   | [...henyu/plugin/grpc/proto/ShenyuGrpcCallRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9wcm90by9TaGVueXVHcnBjQ2FsbFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...plugin/httpclient/config/HttpClientProperties.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9jb25maWcvSHR0cENsaWVudFByb3BlcnRpZXMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../shenyu/plugin/hystrix/builder/HystrixBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9idWlsZGVyL0h5c3RyaXhCdWlsZGVyLmphdmE=) | `98.18% <ø> (-0.04%)` | :arrow_down: |
   | [...u/plugin/modify/response/ModifyResponsePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvTW9kaWZ5UmVzcG9uc2VQbHVnaW4uamF2YQ==) | `18.30% <ø> (ø)` | |
   | [.../response/cache/ModifyResponseRuleHandleCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvY2FjaGUvTW9kaWZ5UmVzcG9uc2VSdWxlSGFuZGxlQ2FjaGUuamF2YQ==) | `66.66% <ø> (-8.34%)` | :arrow_down: |
   | ... and [67 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [52b059b...b625df1](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884#issuecomment-893987772


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1884](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (290bbd8) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fced0b9fa5f8970dd5f9b539638f47a536c050d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fced0b9) will **decrease** coverage by `0.86%`.
   > The diff coverage is `45.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1884      +/-   ##
   ============================================
   - Coverage     68.33%   67.46%   -0.87%     
   - Complexity     2710     2745      +35     
   ============================================
     Files           492      496       +4     
     Lines         11163    11437     +274     
     Branches       1091     1100       +9     
   ============================================
   + Hits           7628     7716      +88     
   - Misses         2959     3139     +180     
   - Partials        576      582       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/apache/dubbo/proxy/ApacheDubboProxyService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vcHJveHkvQXBhY2hlRHViYm9Qcm94eVNlcnZpY2UuamF2YQ==) | `57.69% <ø> (-1.57%)` | :arrow_down: |
   | [...enyu/plugin/grpc/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9BcHBsaWNhdGlvbkNvbmZpZ0NhY2hlLmphdmE=) | `77.50% <ø> (-0.55%)` | :arrow_down: |
   | [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `94.11% <ø> (-0.33%)` | :arrow_down: |
   | [...he/shenyu/plugin/grpc/loadbalance/SubChannels.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9TdWJDaGFubmVscy5qYXZh) | `82.50% <0.00%> (-6.69%)` | :arrow_down: |
   | [...n/grpc/loadbalance/picker/AbstractReadyPicker.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9waWNrZXIvQWJzdHJhY3RSZWFkeVBpY2tlci5qYXZh) | `64.51% <ø> (-1.11%)` | :arrow_down: |
   | [...henyu/plugin/grpc/proto/ShenyuGrpcCallRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9wcm90by9TaGVueXVHcnBjQ2FsbFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...plugin/httpclient/config/HttpClientProperties.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9jb25maWcvSHR0cENsaWVudFByb3BlcnRpZXMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../shenyu/plugin/hystrix/builder/HystrixBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9idWlsZGVyL0h5c3RyaXhCdWlsZGVyLmphdmE=) | `98.18% <ø> (-0.04%)` | :arrow_down: |
   | [...u/plugin/modify/response/ModifyResponsePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvTW9kaWZ5UmVzcG9uc2VQbHVnaW4uamF2YQ==) | `18.30% <ø> (ø)` | |
   | [.../response/cache/ModifyResponseRuleHandleCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvY2FjaGUvTW9kaWZ5UmVzcG9uc2VSdWxlSGFuZGxlQ2FjaGUuamF2YQ==) | `66.66% <ø> (-8.34%)` | :arrow_down: |
   | ... and [61 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fced0b9...290bbd8](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1884: [ISSUE #1866] Remove lombok dependency from

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1884:
URL: https://github.com/apache/incubator-shenyu/pull/1884#issuecomment-893987772


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1884](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (290bbd8) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fced0b9fa5f8970dd5f9b539638f47a536c050d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fced0b9) will **decrease** coverage by `0.73%`.
   > The diff coverage is `46.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1884      +/-   ##
   ============================================
   - Coverage     68.33%   67.59%   -0.74%     
   - Complexity     2710     2745      +35     
   ============================================
     Files           492      496       +4     
     Lines         11163    11437     +274     
     Branches       1091     1100       +9     
   ============================================
   + Hits           7628     7731     +103     
   - Misses         2959     3123     +164     
   - Partials        576      583       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/apache/dubbo/proxy/ApacheDubboProxyService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vcHJveHkvQXBhY2hlRHViYm9Qcm94eVNlcnZpY2UuamF2YQ==) | `57.69% <ø> (-1.57%)` | :arrow_down: |
   | [...enyu/plugin/grpc/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9BcHBsaWNhdGlvbkNvbmZpZ0NhY2hlLmphdmE=) | `77.50% <ø> (-0.55%)` | :arrow_down: |
   | [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `94.11% <ø> (-0.33%)` | :arrow_down: |
   | [...he/shenyu/plugin/grpc/loadbalance/SubChannels.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9TdWJDaGFubmVscy5qYXZh) | `82.50% <0.00%> (-6.69%)` | :arrow_down: |
   | [...n/grpc/loadbalance/picker/AbstractReadyPicker.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9waWNrZXIvQWJzdHJhY3RSZWFkeVBpY2tlci5qYXZh) | `64.51% <ø> (-1.11%)` | :arrow_down: |
   | [...henyu/plugin/grpc/proto/ShenyuGrpcCallRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9wcm90by9TaGVueXVHcnBjQ2FsbFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...plugin/httpclient/config/HttpClientProperties.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9jb25maWcvSHR0cENsaWVudFByb3BlcnRpZXMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../shenyu/plugin/hystrix/builder/HystrixBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9idWlsZGVyL0h5c3RyaXhCdWlsZGVyLmphdmE=) | `98.18% <ø> (-0.04%)` | :arrow_down: |
   | [...u/plugin/modify/response/ModifyResponsePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvTW9kaWZ5UmVzcG9uc2VQbHVnaW4uamF2YQ==) | `18.30% <ø> (ø)` | |
   | [.../response/cache/ModifyResponseRuleHandleCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvY2FjaGUvTW9kaWZ5UmVzcG9uc2VSdWxlSGFuZGxlQ2FjaGUuamF2YQ==) | `66.66% <ø> (-8.34%)` | :arrow_down: |
   | ... and [59 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fced0b9...290bbd8](https://codecov.io/gh/apache/incubator-shenyu/pull/1884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org