[jira] [Commented] (HBASE-6758) [replication] The replication-executor should make sure the file that it is replicating is closed before declaring success on that file

["Jean-Daniel Cryans (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-6758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468728#comment-13468728 ] 

Jean-Daniel Cryans commented on HBASE-6758:
-------------------------------------------

I really don't like that we have to pass down another instance of HRS (through RegionServerServices). The fact that we're now doing this:

{code}
-        new Replication(this, this.fs, logdir, oldLogDir): null;
+        new Replication(this, this.fs, logdir, oldLogDir, this): null;
{code}

is making me sad. Also it leaks all over the code. It seems to me that there should be another way to handle this just in ReplicationSource.

At the moment I'd be +1 for commit only to trunk and on commit this logging will need to cleaned up:

{code}
LOG.info("File " + getCurrentPath() + " in use");
{code}

Is ok with you [~devaraj]?
                
> [replication] The replication-executor should make sure the file that it is replicating is closed before declaring success on that file
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-6758
>                 URL: https://issues.apache.org/jira/browse/HBASE-6758
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 6758-1-0.92.patch, 6758-2-0.92.patch, 6758-trunk-1.patch, TEST-org.apache.hadoop.hbase.replication.TestReplication.xml
>
>
> I have seen cases where the replication-executor would lose data to replicate since the file hasn't been closed yet. Upon closing, the new data becomes visible. Before that happens the ZK node shouldn't be deleted in ReplicationSourceManager.logPositionAndCleanOldLogs. Changes need to be made in ReplicationSource.processEndOfFile as well (currentPath related).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira