[GitHub] [incubator-apisix] membphis commented on a change in pull request #1931: feature: support defined environment variable in config.yaml #1922

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #1931:
URL: https://github.com/apache/incubator-apisix/pull/1931#discussion_r463375557



##########
File path: .travis/apisix_cli_test.sh
##########
@@ -161,3 +161,21 @@ if [ ! $? -eq 0 ]; then
 fi
 
 echo "passed: worker_shutdown_timeout in nginx.conf is ok"
+
+# check custom environment variable in nginx.conf
+make stop
+
+sed  -i 's/#environment:/environment:\n      TNS_ADMIN:\n      DATACENTER_ID: 1/'  conf/config.yaml
+
+make init
+
+set +ex
+ed ":a;N;s/\n//g;ta" conf/nginx.conf |grep -E "env TNS_ADMIN;env DATACENTER_ID=1;" > /dev/null
+if [ ! $? -eq 0 ]; then
+    echo "failed: custom environment variable in nginx.conf is not expect"
+    exit 1
+fi
+
+set -ex
+
+echo "passed: custom environment variable in nginx.conf is ok"

Review comment:
       please add a blank line at the end of the file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org