You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "ranflarion (via GitHub)" <gi...@apache.org> on 2026/10/07 20:00:27 UTC
[PR] fix(spark): return NULL from `char` for a NULL scalar argument [datafusion]
ranflarion opened a new pull request, #26126:
URL: https://github.com/apache/datafusion/pull/26126
## Which issue does this PR close?
- Closes #26125.
## Rationale for this change
`SELECT char(NULL::INT)` fails with `Execution error: The argument must be an Int64 array or scalar.` where Spark returns NULL. NULL rows of an array argument already return NULL, only a NULL scalar argument reaches the error.
## What changes are included in this PR?
`spark_chr` returns a NULL `Utf8` scalar for a NULL `Int64` scalar.
## What is the testing strategy for this PR?
A `char(NULL::INT)` case in `spark/string/char.slt`, which fails on main with the error above.
## Are there any user-facing changes?
`char` of a NULL scalar returns NULL instead of an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix(spark): return NULL from `char` for a NULL scalar argument [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #26126:
URL: https://github.com/apache/datafusion/pull/26126#issuecomment-6046322095
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/26126?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.73%. Comparing base ([`1c43063`](https://app.codecov.io/gh/apache/datafusion/commit/1c430632276cc0e0de2bf5b1a766da8cec84cba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`55bf1e3`](https://app.codecov.io/gh/apache/datafusion/commit/55bf1e3579550ca5cb8b4cd51cdc59f9bf5920f1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #26126 +/- ##
========================================
Coverage 82.73% 82.73%
========================================
Files 1147 1147
Lines 449389 449541 +152
Branches 449389 449541 +152
========================================
+ Hits 371788 371923 +135
- Misses 54943 54944 +1
- Partials 22658 22674 +16
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/26126?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix(spark): return NULL from `char` for a NULL scalar argument [datafusion]
Posted by "neilconway (via GitHub)" <gi...@apache.org>.
neilconway merged PR #26126:
URL: https://github.com/apache/datafusion/pull/26126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org