You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/08/22 11:58:30 UTC
[GitHub] [airflow] potiuk commented on pull request #33608: Add pre-commit hook to validate provider spec
potiuk commented on PR #33608:
URL: https://github.com/apache/airflow/pull/33608#issuecomment-1688046621
Hmm ... we already have `pre_commit_check_provider_yaml_files.py` which does a lot more check on various provider classes and even verifies whether all the classes and packages specified are properly named, imports them etc. etc.
Basically what it does is that it runs
`"python3 /opt/airflow/scripts/in_container/run_provider_yaml_files_check.py" inside breeze and it runs a series of checks there:
```
check_integration_duplicates(all_parsed_yaml_files)
check_duplicates_in_integrations_names_of_hooks_sensors_operators(all_parsed_yaml_files)
check_completeness_of_list_of_transfers(all_parsed_yaml_files)
check_duplicates_in_list_of_transfers(all_parsed_yaml_files)
check_hook_connection_classes(all_parsed_yaml_files)
check_plugin_classes(all_parsed_yaml_files)
check_extra_link_classes(all_parsed_yaml_files)
check_correctness_of_list_of_sensors_operators_hook_modules(all_parsed_yaml_files)
check_unique_provider_name(all_parsed_yaml_files)
check_providers_have_all_documentation_files(all_parsed_yaml_files)
```
So I'd say either the check should be added there, or maybe some of the existing check should be improved there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org