You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Jim Yu (JIRA)" <ji...@apache.org> on 2009/04/29 17:14:30 UTC

[jira] Created: (HARMONY-6188) [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition

[classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition
-----------------------------------------------------------------------------------------------------------------------------------

                 Key: HARMONY-6188
                 URL: https://issues.apache.org/jira/browse/HARMONY-6188
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
    Affects Versions: 5.0M9
            Reporter: Jim Yu
             Fix For: 5.0M10


Currently there are four testcase failures for SimpleDateFormatTest which is in the exclude list. The testcase test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition is one of them. I investigated on this issue and found the failure was mainly caused by the FieldPosition instance was unable to retrieve the correct begin and end index after format method due to ICU requires a DateFormat.Field instance of its own. And other errors were caused by the behavior difference between ICU and  RI. I've got a fix for this failure. The changes of this fix are as following:
1. Update the format method to support FieldPosition index update after formatting.
2. Update the testcase of SimpleDateFormatTest to follow the ICU behavior.
3. Update the testcase in support module to follow the ICU behavior.
Can anybody try this patch?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6188) [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition

Posted by "Jim Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Yu updated HARMONY-6188:
----------------------------

    Attachment: HARMONY-6188-text.diff

> [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6188
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6188
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M9
>            Reporter: Jim Yu
>            Assignee: Tim Ellison
>             Fix For: 5.0M10
>
>         Attachments: HARMONY-6188-support.diff, HARMONY-6188-text.diff
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Currently there are four testcase failures for SimpleDateFormatTest which is in the exclude list. The testcase test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition is one of them. I investigated on this issue and found the failure was mainly caused by the FieldPosition instance was unable to retrieve the correct begin and end index after format method due to ICU requires a DateFormat.Field instance of its own. And other errors were caused by the behavior difference between ICU and  RI. I've got a fix for this failure. The changes of this fix are as following:
> 1. Update the format method to support FieldPosition index update after formatting.
> 2. Update the testcase of SimpleDateFormatTest to follow the ICU behavior.
> 3. Update the testcase in support module to follow the ICU behavior.
> Can anybody try this patch?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-6188) [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition

Posted by "Jim Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Yu closed HARMONY-6188.
---------------------------


Verified at r772235. Thanks, Tim!

> [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6188
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6188
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M9
>            Reporter: Jim Yu
>            Assignee: Tim Ellison
>             Fix For: 5.0M10
>
>         Attachments: HARMONY-6188-support.diff, HARMONY-6188-text.diff
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Currently there are four testcase failures for SimpleDateFormatTest which is in the exclude list. The testcase test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition is one of them. I investigated on this issue and found the failure was mainly caused by the FieldPosition instance was unable to retrieve the correct begin and end index after format method due to ICU requires a DateFormat.Field instance of its own. And other errors were caused by the behavior difference between ICU and  RI. I've got a fix for this failure. The changes of this fix are as following:
> 1. Update the format method to support FieldPosition index update after formatting.
> 2. Update the testcase of SimpleDateFormatTest to follow the ICU behavior.
> 3. Update the testcase in support module to follow the ICU behavior.
> Can anybody try this patch?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-6188) [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison reassigned HARMONY-6188:
------------------------------------

    Assignee: Tim Ellison

> [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6188
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6188
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M9
>            Reporter: Jim Yu
>            Assignee: Tim Ellison
>             Fix For: 5.0M10
>
>         Attachments: HARMONY-6188-support.diff, HARMONY-6188-text.diff
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Currently there are four testcase failures for SimpleDateFormatTest which is in the exclude list. The testcase test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition is one of them. I investigated on this issue and found the failure was mainly caused by the FieldPosition instance was unable to retrieve the correct begin and end index after format method due to ICU requires a DateFormat.Field instance of its own. And other errors were caused by the behavior difference between ICU and  RI. I've got a fix for this failure. The changes of this fix are as following:
> 1. Update the format method to support FieldPosition index update after formatting.
> 2. Update the testcase of SimpleDateFormatTest to follow the ICU behavior.
> 3. Update the testcase in support module to follow the ICU behavior.
> Can anybody try this patch?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6188) [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition

Posted by "Jim Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Yu updated HARMONY-6188:
----------------------------

    Attachment: HARMONY-6188-support.diff

> [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6188
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6188
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M9
>            Reporter: Jim Yu
>             Fix For: 5.0M10
>
>         Attachments: HARMONY-6188-support.diff, HARMONY-6188-text.diff
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Currently there are four testcase failures for SimpleDateFormatTest which is in the exclude list. The testcase test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition is one of them. I investigated on this issue and found the failure was mainly caused by the FieldPosition instance was unable to retrieve the correct begin and end index after format method due to ICU requires a DateFormat.Field instance of its own. And other errors were caused by the behavior difference between ICU and  RI. I've got a fix for this failure. The changes of this fix are as following:
> 1. Update the format method to support FieldPosition index update after formatting.
> 2. Update the testcase of SimpleDateFormatTest to follow the ICU behavior.
> 3. Update the testcase in support module to follow the ICU behavior.
> Can anybody try this patch?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6188) [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition

Posted by "Jim Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Yu updated HARMONY-6188:
----------------------------

    Attachment:     (was: HARMONY-6188-text.diff)

> [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6188
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6188
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M9
>            Reporter: Jim Yu
>            Assignee: Tim Ellison
>             Fix For: 5.0M10
>
>         Attachments: HARMONY-6188-support.diff, HARMONY-6188-text.diff
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Currently there are four testcase failures for SimpleDateFormatTest which is in the exclude list. The testcase test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition is one of them. I investigated on this issue and found the failure was mainly caused by the FieldPosition instance was unable to retrieve the correct begin and end index after format method due to ICU requires a DateFormat.Field instance of its own. And other errors were caused by the behavior difference between ICU and  RI. I've got a fix for this failure. The changes of this fix are as following:
> 1. Update the format method to support FieldPosition index update after formatting.
> 2. Update the testcase of SimpleDateFormatTest to follow the ICU behavior.
> 3. Update the testcase in support module to follow the ICU behavior.
> Can anybody try this patch?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6188) [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition

Posted by "Jim Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Yu updated HARMONY-6188:
----------------------------

    Attachment: HARMONY-6188-text.diff

> [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6188
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6188
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M9
>            Reporter: Jim Yu
>             Fix For: 5.0M10
>
>         Attachments: HARMONY-6188-text.diff
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Currently there are four testcase failures for SimpleDateFormatTest which is in the exclude list. The testcase test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition is one of them. I investigated on this issue and found the failure was mainly caused by the FieldPosition instance was unable to retrieve the correct begin and end index after format method due to ICU requires a DateFormat.Field instance of its own. And other errors were caused by the behavior difference between ICU and  RI. I've got a fix for this failure. The changes of this fix are as following:
> 1. Update the format method to support FieldPosition index update after formatting.
> 2. Update the testcase of SimpleDateFormatTest to follow the ICU behavior.
> 3. Update the testcase in support module to follow the ICU behavior.
> Can anybody try this patch?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-6188) [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison resolved HARMONY-6188.
----------------------------------

    Resolution: Fixed

Thanks Jim.

Patch applied to TEXT and SUPPORT module at repo revision r772226.

I removed part of the patch that overlaps with HARMONY-6181.

Please verify it was applied as you expected.


> [classlib][text] Fix the failure for SimpleDateFormatTest.test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6188
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6188
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M9
>            Reporter: Jim Yu
>            Assignee: Tim Ellison
>             Fix For: 5.0M10
>
>         Attachments: HARMONY-6188-support.diff, HARMONY-6188-text.diff
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Currently there are four testcase failures for SimpleDateFormatTest which is in the exclude list. The testcase test_formatLjava_util_DateLjava_lang_StringBufferLjava_text_FieldPosition is one of them. I investigated on this issue and found the failure was mainly caused by the FieldPosition instance was unable to retrieve the correct begin and end index after format method due to ICU requires a DateFormat.Field instance of its own. And other errors were caused by the behavior difference between ICU and  RI. I've got a fix for this failure. The changes of this fix are as following:
> 1. Update the format method to support FieldPosition index update after formatting.
> 2. Update the testcase of SimpleDateFormatTest to follow the ICU behavior.
> 3. Update the testcase in support module to follow the ICU behavior.
> Can anybody try this patch?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.