You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/12 00:27:56 UTC
[GitHub] [openwhisk-wskdebug] alexkli opened a new issue #22: make ngrok an
optional dependency
alexkli opened a new issue #22: make ngrok an optional dependency
URL: https://github.com/apache/openwhisk-wskdebug/issues/22
`ngrok` installation requires `--unsafe-perm=true` in the install script, which is unusual and should be avoided for the main installation instructions.
It is already an optional feature only triggered by `--ngrok`, so it is probably better to make it an optional npm dependency and ask people to install it separately using `npm install -g ngrok --unsafe-perm=true` if needed.
- move `ngrok` to `optionalDependencies`
- load only if needed (`--ngrok` argument specified ) as [illustrated here](https://npm.github.io/using-pkgs-docs/package-json/types/optionaldependencies.html)
- if not installed, give error message explaining how to install it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdebug] alexkli closed issue #22: make ngrok an
optional dependency
Posted by GitBox <gi...@apache.org>.
alexkli closed issue #22: make ngrok an optional dependency
URL: https://github.com/apache/openwhisk-wskdebug/issues/22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdebug] alexkli commented on issue #22: make ngrok an
optional dependency
Posted by GitBox <gi...@apache.org>.
alexkli commented on issue #22: make ngrok an optional dependency
URL: https://github.com/apache/openwhisk-wskdebug/issues/22#issuecomment-612150232
Had to use `peerDependencies` instead of `optionalDependencies` in #39.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services