You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Ayoubhm07 (via GitHub)" <gi...@apache.org> on 2026/10/06 10:17:11 UTC
[PR] [Python] Remove leftover "### Labels" debug log in the BigQuery source [beam]
Ayoubhm07 opened a new pull request, #40430:
URL: https://github.com/apache/beam/pull/40430
`_CustomBigQueryStorageSource._setup_temporary_dataset` logs the dataset labels at warning level, right before passing the same value to `create_temporary_dataset` :
https://github.com/apache/beam/blob/c74609d71eeae8127cd8fa6b1c06a2c9e92422a5/sdks/python/apache_beam/io/gcp/bigquery.py#L1152
Three things suggest a debug print rather than an intended log line :
- `###` appears in no other logging call under `sdks/python/apache_beam`, across its 1380 `.py` files
- `str()` is redundant with `%s`
- it is the only `_LOGGER.warning(...)` call in the module, and it reports a value the caller supplied in the first place
`git blame` puts the line in #15602, which added the BigQuery Read API support in October 2021, and it has not changed since
No test refers to it : the only `assertLogs` in `io/gcp` is `bigquery_test.py:398`, which targets a DEBUG message from `bigquery_read_internal` on an unrelated path
`_LOGGER` is still used at nine call sites in the module, so nothing becomes unused
Checked with `yapf==0.43.0`, the version pinned in `tox.ini:294` : no diff
If you would rather keep the value visible, I am happy to demote it to `debug` instead of removing it
------------------------
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
- not applicable, no issue filed for a one-line log removal
- [ ] Update `CHANGES.md` with noteworthy changes.
- not noteworthy, removing a debug log changes no behaviour and no API
- [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
- one line removed, no ICLA needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Remove leftover "### Labels" debug log in the BigQuery source [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40430:
URL: https://github.com/apache/beam/pull/40430#issuecomment-6014534356
Assigning reviewers:
R: @jrmccluskey for label python.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Remove leftover "### Labels" debug log in the BigQuery source [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40430:
URL: https://github.com/apache/beam/pull/40430#issuecomment-6018846044
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/40430?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 59.04%. Comparing base ([`69bdf5f`](https://app.codecov.io/gh/apache/beam/commit/69bdf5f29174adebe19006e1397acd6681ffce9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283c6c6`](https://app.codecov.io/gh/apache/beam/commit/283c6c6b1a892b9746b649efb0f6b9714d6870db?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 22 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40430 +/- ##
=========================================
Coverage 59.04% 59.04%
Complexity 15624 15624
=========================================
Files 2797 2797
Lines 280750 280787 +37
Branches 12488 12488
=========================================
+ Hits 165764 165796 +32
- Misses 108540 108545 +5
Partials 6446 6446
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/40430/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/40430/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.67% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/beam/pull/40430?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Remove leftover "### Labels" debug log in the BigQuery source [beam]
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey merged PR #40430:
URL: https://github.com/apache/beam/pull/40430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org