You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Raymond (Jira)" <ji...@apache.org> on 2022/11/16 08:26:00 UTC
[jira] [Commented] (CAMEL-18724) Add defaults for options for the Throttle EIP in the documentation
[ https://issues.apache.org/jira/browse/CAMEL-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634721#comment-17634721 ]
Raymond commented on CAMEL-18724:
---------------------------------
I can create a PR myself, but don't know which file to change.
There is this page:
[https://github.com/apache/camel/blob/main/core/camel-core-engine/src/main/docs/modules/eips/pages/throttle-eip.adoc]
But that one links to: [partial$eip-options.adoc|https://github.com/apache/camel/blob/main/core/camel-core-engine/src/main/docs/modules/eips/pages/partial$eip-options.adoc]
It seems that this page gets its values from a json file, but it doesn't seem to be
[https://github.com/apache/camel/blob/main/core/camel-core-model/src/generated/resources/org/apache/camel/model/throttle.json]
As this file is generated and already contains the default.
Should the PR made for main or for example 2.20.x branch?
> Add defaults for options for the Throttle EIP in the documentation
> -------------------------------------------------------------------
>
> Key: CAMEL-18724
> URL: https://issues.apache.org/jira/browse/CAMEL-18724
> Project: Camel
> Issue Type: Improvement
> Components: documentation, eip
> Affects Versions: 3.19.0
> Reporter: Raymond
> Priority: Trivial
> Fix For: 3.20.0
>
>
> In the documentation of the throttle EIP:
> [https://camel.apache.org/components/next/eips/throttle-eip.html]
> There are several Boolean options like:
> **
> * *asyncDelayed*
> * *rejectExecution*
> * {*}disabled{*}{*}{{*}}
> According to the documentation, they don't have default options, but every optional value has one:
> * *asyncDelayed (Default=true)*
> * *rejectExecution (Default=false)*
> * *disabled (Default=false)*
> **
> See: [https://github.com/apache/camel/blob/main/core/camel-core-model/src/generated/resources/org/apache/camel/model/throttle.json]
> Maybe clearer to add them
--
This message was sent by Atlassian Jira
(v8.20.10#820010)