You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@iceberg.apache.org by Manu Zhang <ow...@gmail.com> on 2022/09/15 05:24:45 UTC

Request PR review

Hi all,

May I have more eyes on https://github.com/apache/iceberg/pull/5392?
I've addressed previous comments and we've seen huge performance
improvement with compaction on a large number of partitions (e.g. 10k)
after the fix.

Thanks,
Manu

Re: Request PR review

Posted by Manu Zhang <ow...@gmail.com>.

With previous comments addressed, I'm wondering if I can get another review
or the PR merged. There is already one approval.

Thanks,
Manu

On Thu, Nov 3, 2022 at 9:48 AM Manu Zhang <ow...@gmail.com> wrote:

> Thanks Ryan for previous comments. Could you please review again?
> There is already one approval.
>
> Thanks,
> Manu
>
> On Thu, Oct 20, 2022 at 11:41 PM Ryan Blue <bl...@tabular.io> wrote:
>
>> Thanks, Manu. I'll take a look today.
>>
>> On Wed, Oct 19, 2022 at 7:16 PM Manu Zhang <ow...@gmail.com>
>> wrote:
>>
>>> Can someone take another look at my PR? It's been two months without any
>>> comments.
>>>
>>> Thanks,
>>> Manu
>>>
>>> On Thu, Sep 15, 2022 at 1:24 PM Manu Zhang <ow...@gmail.com>
>>> wrote:
>>>
>>>> Hi all,
>>>>
>>>> May I have more eyes on https://github.com/apache/iceberg/pull/5392?
>>>> I've addressed previous comments and we've seen huge performance
>>>> improvement with compaction on a large number of partitions (e.g. 10k)
>>>> after the fix.
>>>>
>>>> Thanks,
>>>> Manu
>>>>
>>>
>>
>> --
>> Ryan Blue
>> Tabular
>>
>

Re: Request PR review

Posted by Manu Zhang <ow...@gmail.com>.

Thanks Ryan for previous comments. Could you please review again?
There is already one approval.

Thanks,
Manu

On Thu, Oct 20, 2022 at 11:41 PM Ryan Blue <bl...@tabular.io> wrote:

> Thanks, Manu. I'll take a look today.
>
> On Wed, Oct 19, 2022 at 7:16 PM Manu Zhang <ow...@gmail.com>
> wrote:
>
>> Can someone take another look at my PR? It's been two months without any
>> comments.
>>
>> Thanks,
>> Manu
>>
>> On Thu, Sep 15, 2022 at 1:24 PM Manu Zhang <ow...@gmail.com>
>> wrote:
>>
>>> Hi all,
>>>
>>> May I have more eyes on https://github.com/apache/iceberg/pull/5392?
>>> I've addressed previous comments and we've seen huge performance
>>> improvement with compaction on a large number of partitions (e.g. 10k)
>>> after the fix.
>>>
>>> Thanks,
>>> Manu
>>>
>>
>
> --
> Ryan Blue
> Tabular
>

Re: Request PR review

Posted by Ryan Blue <bl...@tabular.io>.

Thanks, Manu. I'll take a look today.

On Wed, Oct 19, 2022 at 7:16 PM Manu Zhang <ow...@gmail.com> wrote:

> Can someone take another look at my PR? It's been two months without any
> comments.
>
> Thanks,
> Manu
>
> On Thu, Sep 15, 2022 at 1:24 PM Manu Zhang <ow...@gmail.com>
> wrote:
>
>> Hi all,
>>
>> May I have more eyes on https://github.com/apache/iceberg/pull/5392?
>> I've addressed previous comments and we've seen huge performance
>> improvement with compaction on a large number of partitions (e.g. 10k)
>> after the fix.
>>
>> Thanks,
>> Manu
>>
>

-- 
Ryan Blue
Tabular

Re: Request PR review

Posted by Manu Zhang <ow...@gmail.com>.

Can someone take another look at my PR? It's been two months without any
comments.

Thanks,
Manu

On Thu, Sep 15, 2022 at 1:24 PM Manu Zhang <ow...@gmail.com> wrote:

> Hi all,
>
> May I have more eyes on https://github.com/apache/iceberg/pull/5392?
> I've addressed previous comments and we've seen huge performance
> improvement with compaction on a large number of partitions (e.g. 10k)
> after the fix.
>
> Thanks,
> Manu
>