You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/01/30 09:08:47 UTC

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5030: Support cast as a transform function

fx19880617 opened a new pull request #5030: Support cast as a transform function
URL: https://github.com/apache/incubator-pinot/pull/5030
 
 
   adding cast function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5030: Support cast as a transform function

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5030: Support cast as a transform function
URL: https://github.com/apache/incubator-pinot/pull/5030#issuecomment-580215784
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=h1) Report
   > Merging [#5030](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9b5bdbb56d8628e3e650ebb0716f76438e65bf27?src=pr&el=desc) will **decrease** coverage by `19.42%`.
   > The diff coverage is `57.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5030/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5030       +/-   ##
   =============================================
   - Coverage     58.71%   39.29%   -19.43%     
   =============================================
     Files          1181     1182        +1     
     Lines         63102    63130       +28     
     Branches       9287     9290        +3     
   =============================================
   - Hits          37049    24804    -12245     
   - Misses        23329    36161    +12832     
   + Partials       2724     2165      -559
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `86.66% <100%> (+0.45%)` | `0 <0> (ø)` | :arrow_down: |
   | [...r/transform/function/TransformFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25GYWN0b3J5LmphdmE=) | `67.74% <100%> (-4.39%)` | `0 <0> (ø)` | |
   | [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | `59.24% <50%> (-31.02%)` | `0 <0> (ø)` | |
   | [...ator/transform/function/CastTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQ2FzdFRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | `54.16% <54.16%> (ø)` | `0 <0> (?)` | |
   | [.../org/apache/pinot/common/http/MultiGetRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vaHR0cC9NdWx0aUdldFJlcXVlc3QuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...che/pinot/common/restlet/resources/TablesList.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzdGxldC9yZXNvdXJjZXMvVGFibGVzTGlzdC5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...che/pinot/pql/parsers/pql2/ast/OptionsAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9PcHRpb25zQXN0Tm9kZS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...ot/core/query/scheduler/TableBasedGroupMapper.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zY2hlZHVsZXIvVGFibGVCYXNlZEdyb3VwTWFwcGVyLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...t/core/segment/index/readers/OnHeapDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvT25IZWFwRGljdGlvbmFyeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...t/core/query/scheduler/OutOfCapacityException.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zY2hlZHVsZXIvT3V0T2ZDYXBhY2l0eUV4Y2VwdGlvbi5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | ... and [573 more](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=footer). Last update [9b5bdbb...e55270a](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] jackjlli commented on issue #5030: Support cast as a transform function

Posted by GitBox <gi...@apache.org>.
jackjlli commented on issue #5030: Support cast as a transform function
URL: https://github.com/apache/incubator-pinot/pull/5030#issuecomment-594079028
 
 
   @fx19880617 I found a flaky test coming from this PR. Can you help take a look at it?
   ```
   java.lang.AssertionError: Value: 0 does not match, expected: 95455, got broker value: 95461, got client value:95461
   PQL: SELECT COUNT(WeatherDelay) FROM mytable WHERE  ArrDelay - CarrierDelay > 0 LIMIT 26
   SQL: [SELECT COUNT(WeatherDelay) FROM mytable WHERE  ArrDelay - CarrierDelay > 0 LIMIT 26]
   	at org.testng.Assert.fail(Assert.java:93)
   	at org.apache.pinot.integration.tests.ClusterIntegrationTestUtils.failure(ClusterIntegrationTestUtils.java:1010)
   	at org.apache.pinot.integration.tests.ClusterIntegrationTestUtils.failure(ClusterIntegrationTestUtils.java:1025)
   	at org.apache.pinot.integration.tests.ClusterIntegrationTestUtils.testSqlQuery(ClusterIntegrationTestUtils.java:940)
   	at org.apache.pinot.integration.tests.BaseClusterIntegrationTest.testSqlQuery(BaseClusterIntegrationTest.java:395)
   	at org.apache.pinot.integration.tests.BaseClusterIntegrationTestSet.testSqlQueriesFromQueryFile(BaseClusterIntegrationTestSet.java:341)
   	at org.apache.pinot.integration.tests.RealtimeClusterIntegrationTest.testSqlQueriesFromQueryFile(RealtimeClusterIntegrationTest.java:178)
   	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.lang.reflect.Method.invoke(Method.java:498)
   	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:108)
   	at org.testng.internal.Invoker.invokeMethod(Invoker.java:661)
   	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:869)
   	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1193)
   	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:126)
   	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:109)
   	at org.testng.TestRunner.privateRun(TestRunner.java:744)
   	at org.testng.TestRunner.run(TestRunner.java:602)
   	at org.testng.SuiteRunner.runTest(SuiteRunner.java:380)
   	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:375)
   	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:340)
   	at org.testng.SuiteRunner.run(SuiteRunner.java:289)
   	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
   	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
   	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1301)
   	at org.testng.TestNG.runSuitesLocally(TestNG.java:1226)
   	at org.testng.TestNG.runSuites(TestNG.java:1144)
   	at org.testng.TestNG.run(TestNG.java:1115)
   	at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:132)
   	at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:134)
   	at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:118)
   	at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:146)
   	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:286)
   	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:240)
   	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] fx19880617 commented on issue #5030: Support cast as a transform function

Posted by GitBox <gi...@apache.org>.
fx19880617 commented on issue #5030: Support cast as a transform function
URL: https://github.com/apache/incubator-pinot/pull/5030#issuecomment-594120193
 
 
   > @fx19880617 I found a flaky test coming from this PR. Can you help take a look at it?
   > 
   > ```
   > java.lang.AssertionError: Value: 0 does not match, expected: 95455, got broker value: 95461, got client value:95461
   > PQL: SELECT COUNT(WeatherDelay) FROM mytable WHERE  ArrDelay - CarrierDelay > 0 LIMIT 26
   > SQL: [SELECT COUNT(WeatherDelay) FROM mytable WHERE  ArrDelay - CarrierDelay > 0 LIMIT 26]
   > 	at org.testng.Assert.fail(Assert.java:93)
   > 	at org.apache.pinot.integration.tests.ClusterIntegrationTestUtils.failure(ClusterIntegrationTestUtils.java:1010)
   > 	at org.apache.pinot.integration.tests.ClusterIntegrationTestUtils.failure(ClusterIntegrationTestUtils.java:1025)
   > 	at org.apache.pinot.integration.tests.ClusterIntegrationTestUtils.testSqlQuery(ClusterIntegrationTestUtils.java:940)
   > 	at org.apache.pinot.integration.tests.BaseClusterIntegrationTest.testSqlQuery(BaseClusterIntegrationTest.java:395)
   > 	at org.apache.pinot.integration.tests.BaseClusterIntegrationTestSet.testSqlQueriesFromQueryFile(BaseClusterIntegrationTestSet.java:341)
   > 	at org.apache.pinot.integration.tests.RealtimeClusterIntegrationTest.testSqlQueriesFromQueryFile(RealtimeClusterIntegrationTest.java:178)
   > 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   > 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   > 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   > 	at java.lang.reflect.Method.invoke(Method.java:498)
   > 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:108)
   > 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:661)
   > 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:869)
   > 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1193)
   > 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:126)
   > 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:109)
   > 	at org.testng.TestRunner.privateRun(TestRunner.java:744)
   > 	at org.testng.TestRunner.run(TestRunner.java:602)
   > 	at org.testng.SuiteRunner.runTest(SuiteRunner.java:380)
   > 	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:375)
   > 	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:340)
   > 	at org.testng.SuiteRunner.run(SuiteRunner.java:289)
   > 	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
   > 	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
   > 	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1301)
   > 	at org.testng.TestNG.runSuitesLocally(TestNG.java:1226)
   > 	at org.testng.TestNG.runSuites(TestNG.java:1144)
   > 	at org.testng.TestNG.run(TestNG.java:1115)
   > 	at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:132)
   > 	at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:134)
   > 	at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:118)
   > 	at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:146)
   > 	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:286)
   > 	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:240)
   > 	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
   > ```
   
   This is tracked at https://github.com/apache/incubator-pinot/issues/5103

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io commented on issue #5030: Support cast as a transform function

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5030: Support cast as a transform function
URL: https://github.com/apache/incubator-pinot/pull/5030#issuecomment-580215784
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=h1) Report
   > Merging [#5030](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9232f59ed41c8f747dcf0a645eeca5c534121022?src=pr&el=desc) will **increase** coverage by `0.06%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5030/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5030      +/-   ##
   ============================================
   + Coverage     58.57%   58.64%   +0.06%     
     Complexity       12       12              
   ============================================
     Files          1181     1182       +1     
     Lines         63102    63126      +24     
     Branches       9287     9289       +2     
   ============================================
   + Hits          36965    37020      +55     
   + Misses        23418    23368      -50     
   - Partials       2719     2738      +19
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...r/transform/function/TransformFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25GYWN0b3J5LmphdmE=) | `72.58% <100%> (+0.44%)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `86.66% <100%> (+0.45%)` | `0 <0> (ø)` | :arrow_down: |
   | [...ator/transform/function/CastTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQ2FzdFRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | `81.81% <81.81%> (ø)` | `0 <0> (?)` | |
   | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | |
   | [...org/apache/pinot/broker/queryquota/HitCounter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IaXRDb3VudGVyLmphdmE=) | `92.3% <0%> (-7.7%)` | `0% <0%> (ø)` | |
   | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `63.41% <0%> (-7.32%)` | `0% <0%> (ø)` | |
   | [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `63.41% <0%> (-7.32%)` | `0% <0%> (ø)` | |
   | [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `61.29% <0%> (-5.38%)` | `0% <0%> (ø)` | |
   | [...org/apache/pinot/client/DynamicBrokerSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0R5bmFtaWNCcm9rZXJTZWxlY3Rvci5qYXZh) | `69.69% <0%> (-3.04%)` | `0% <0%> (ø)` | |
   | [.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb24uamF2YQ==) | `47.61% <0%> (-2.39%)` | `0% <0%> (ø)` | |
   | ... and [28 more](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=footer). Last update [9232f59...04943e5](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5030: Support cast as a transform function

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5030: Support cast as a transform function
URL: https://github.com/apache/incubator-pinot/pull/5030#issuecomment-580215784
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=h1) Report
   > Merging [#5030](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9b5bdbb56d8628e3e650ebb0716f76438e65bf27?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `85.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5030/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5030      +/-   ##
   ============================================
   + Coverage     58.71%   58.71%   +<.01%     
     Complexity       12       12              
   ============================================
     Files          1181     1182       +1     
     Lines         63102    63130      +28     
     Branches       9287     9290       +3     
   ============================================
   + Hits          37049    37069      +20     
   - Misses        23329    23340      +11     
   + Partials       2724     2721       -3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `86.66% <100%> (+0.45%)` | `0 <0> (ø)` | :arrow_down: |
   | [...r/transform/function/TransformFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25GYWN0b3J5LmphdmE=) | `72.58% <100%> (+0.44%)` | `0 <0> (ø)` | :arrow_down: |
   | [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | `93.27% <50%> (+3.02%)` | `0 <0> (ø)` | :arrow_down: |
   | [...ator/transform/function/CastTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQ2FzdFRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | `87.5% <87.5%> (ø)` | `0 <0> (?)` | |
   | [.../org/apache/pinot/client/PinotClientException.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L1Bpbm90Q2xpZW50RXhjZXB0aW9uLmphdmE=) | `33.33% <0%> (-33.34%)` | `0% <0%> (ø)` | |
   | [.../broker/routing/builder/InstanceConfigManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL0luc3RhbmNlQ29uZmlnTWFuYWdlci5qYXZh) | `85.71% <0%> (-14.29%)` | `0% <0%> (ø)` | |
   | [...inot/client/JsonAsyncHttpPinotClientTransport.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0pzb25Bc3luY0h0dHBQaW5vdENsaWVudFRyYW5zcG9ydC5qYXZh) | `62% <0%> (-14%)` | `0% <0%> (ø)` | |
   | [...pinot/core/operator/docidsets/OrBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvT3JCbG9ja0RvY0lkU2V0LmphdmE=) | `84.9% <0%> (-9.44%)` | `0% <0%> (ø)` | |
   | [...pinot/broker/api/resources/PinotClientRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYXBpL3Jlc291cmNlcy9QaW5vdENsaWVudFJlcXVlc3QuamF2YQ==) | `23.4% <0%> (-8.52%)` | `0% <0%> (ø)` | |
   | [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlbG9jYXRpb24vUmVhbHRpbWVTZWdtZW50UmVsb2NhdG9yLmphdmE=) | `36.84% <0%> (-7.9%)` | `0% <0%> (ø)` | |
   | ... and [32 more](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=footer). Last update [9b5bdbb...b3c0074](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5030: Support cast as a transform function

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5030: Support cast as a transform function
URL: https://github.com/apache/incubator-pinot/pull/5030#issuecomment-580215784
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=h1) Report
   > Merging [#5030](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9b5bdbb56d8628e3e650ebb0716f76438e65bf27?src=pr&el=desc) will **decrease** coverage by `6.85%`.
   > The diff coverage is `78.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5030/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5030      +/-   ##
   ============================================
   - Coverage     58.71%   51.85%   -6.86%     
     Complexity       12       12              
   ============================================
     Files          1181     1182       +1     
     Lines         63102    63130      +28     
     Branches       9287     9290       +3     
   ============================================
   - Hits          37049    32735    -4314     
   - Misses        23329    27873    +4544     
   + Partials       2724     2522     -202
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `86.66% <100%> (+0.45%)` | `0 <0> (ø)` | :arrow_down: |
   | [...r/transform/function/TransformFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25GYWN0b3J5LmphdmE=) | `72.58% <100%> (+0.44%)` | `0 <0> (ø)` | :arrow_down: |
   | [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | `89.91% <50%> (-0.34%)` | `0 <0> (ø)` | |
   | [...ator/transform/function/CastTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQ2FzdFRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | `79.16% <79.16%> (ø)` | `0 <0> (?)` | |
   | [...ot/minion/events/EventObserverFactoryRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXZlbnRzL0V2ZW50T2JzZXJ2ZXJGYWN0b3J5UmVnaXN0cnkuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...minion/executor/ConvertToRawIndexTaskExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvQ29udmVydFRvUmF3SW5kZXhUYXNrRXhlY3V0b3IuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...a/org/apache/pinot/minion/metrics/MinionMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25NZXRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [.../apache/pinot/minion/metrics/MinionQueryPhase.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25RdWVyeVBoYXNlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...nion/events/DefaultMinionEventObserverFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXZlbnRzL0RlZmF1bHRNaW5pb25FdmVudE9ic2VydmVyRmFjdG9yeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...executor/ConvertToRawIndexTaskExecutorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvQ29udmVydFRvUmF3SW5kZXhUYXNrRXhlY3V0b3JGYWN0b3J5LmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | ... and [257 more](https://codecov.io/gh/apache/incubator-pinot/pull/5030/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=footer). Last update [9b5bdbb...e55270a](https://codecov.io/gh/apache/incubator-pinot/pull/5030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] fx19880617 merged pull request #5030: Support cast as a transform function

Posted by GitBox <gi...@apache.org>.
fx19880617 merged pull request #5030: Support cast as a transform function
URL: https://github.com/apache/incubator-pinot/pull/5030
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org