[GitHub] michellethomas opened a new pull request #4207: Adding limit to time_table viz to get druid query to work

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #4207: Adding limit to time_table viz to get druid query to work
URL: https://github.com/apache/incubator-superset/pull/4207
 
 
   @graceguo-supercat @john-bodley Adding the limit control on the time series table visualization.
   
   In the druid run_query [here](https://github.com/apache/incubator-superset/blob/master/superset/connectors/druid/models.py#L1058) a `Phase 1` query is created if `timeseries_limit == 0`, but that results in an incorrect query if the limit field is not present. There are parts of the Phase 2 query that are necessary. I'm not as familiar with this part of the code so I'm just adding a temporary fix to get the time table viz working. But this also causes problems if you remove the `limit` on a line chart. 
   
   @mistercrunch would you suggest having different logic for determining phase = 1 or pulling the necessary logic out of phase 2 and into phase 1?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services