[I] Add a run_validation test so the organization-structure check cannot be silently unwired [magpie]

["justinmclean (via GitHub)" <gi...@apache.org>]

justinmclean opened a new issue, #977:
URL: https://github.com/apache/magpie/issues/977

   ## Summary
   
   The validator's organization-structure check has eight tests, all of which call the check
   function directly. None of them notice if the check stops being called by the validator's entry
   point. Add one test that goes through `run_validation`.
   
   ## Background
   
   `validate_organization_structure` reaches real runs through a single line in
   `run_validation()`. Every test in `TestOrganizationStructure` imports and calls the function
   itself, so deleting that one line leaves the whole suite green while the check silently stops
   running for everyone.
   
   There is one existing test that calls `run_validation()` against the real repository, but it
   asserts that no hard violations exist — and since the live `ASF/` and `independent/` adapters
   both have their required files, it passes whether or not the check is wired in.
   
   This is a small, self-contained gap and a good way to see how the validator is assembled.
   
   ## Where to look
   
   - `tools/skill-and-tool-validator/tests/test_validator.py` — the `TestOrganizationStructure`
     class is where the new test belongs. Its `_make_org` helper already builds an org directory
     under `tmp_path`.
   - `tools/skill-and-tool-validator/src/skill_and_tool_validator/__init__.py` — find
     `def run_validation` and look for the `validate_organization_structure` line to see the
     wiring you are protecting.
   - Other tests in the same file call `run_validation(tmp_path)` and filter the result by
     category; use them as the model.
   
   ## Acceptance criteria
   
   - [ ] A new test builds an organization directory missing a required file under `tmp_path` and
         asserts the violation appears in the output of `run_validation(tmp_path)`.
   - [ ] The test fails when the `validate_organization_structure` line is removed from
         `run_validation` (check this, then put the line back).
   - [ ] The validator's existing tests still pass.
   
   ## Estimated effort
   
   ~1 hour for someone new to the codebase.
   
   ## Getting started
   
   [[How to contribute](https://github.com/apache/airflow-steward/blob/main/CONTRIBUTING.md#your-first-contribution)](https://github.com/apache/airflow-steward/blob/main/CONTRIBUTING.md#your-first-contribution)
   
   This issue was drafted with the help of an AI-assisted tool and reviewed by a Magpie maintainer before posting. If anything here is unclear or looks wrong, say so on the issue: a real person is reading.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Add a run_validation test so the organization-structure check cannot be silently unwired [magpie]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk closed issue #977: Add a run_validation test so the organization-structure check cannot be silently unwired
URL: https://github.com/apache/magpie/issues/977


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Add a run_validation test so the organization-structure check cannot be silently unwired [magpie]

["Shaurya2k06 (via GitHub)" <gi...@apache.org>]

Shaurya2k06 commented on issue #977:
URL: https://github.com/apache/magpie/issues/977#issuecomment-5100482894

   Happy to work on this. Could it be assigned to me, or do you think it's better to leave the rest out for newer contributors? 
   cc @justinmclean 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Add a run_validation test so the organization-structure check cannot be silently unwired [magpie]

["justinmclean (via GitHub)" <gi...@apache.org>]

justinmclean commented on issue #977:
URL: https://github.com/apache/magpie/issues/977#issuecomment-5100511336

   You can keep working on them - that's fine my me. I'm going to try to put some more good first issues up every day - but they will eventually be harder to generate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org